Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] 체크리스트리스트 API, 방 비교 API 리팩토링 반영 #170

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

JINU-CHANG
Copy link
Contributor

@JINU-CHANG JINU-CHANG commented Jul 29, 2024

❗ Issue

✨ 구현한 기능

  • 논의사항 전부 반영해서 리팩토링 완료했습니다.
  • 방 비교 API 관련 테스트코드 추가했습니다.

📢 논의하고 싶은 내용

  • 코멘트 확인해주세요!

🎸 기타

@@ -27,4 +25,6 @@ default Checklist getById(long id) {
List<Checklist> findByUser(User user);

List<Checklist> findByUserAndIdIn(User user, List<Long> checklistIds);

long countAllByIdIn(List<Long> ids);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체크리스트 아이디가 존재하는지 확인하기 위해 사용되는 메서드인데요,
existsAllByIdIn 을 사용하고 싶었지만 동작하지 않더라구요 🥲
더 좋은 방식이 있다면 알려주세요~

@JINU-CHANG JINU-CHANG merged commit ea3a056 into dev-be Jul 30, 2024
1 check passed
@JINU-CHANG JINU-CHANG deleted the refactor/130-new branch July 30, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant