[FE] 변경된 API 인터페이스에 맞게 타입을 변경한다. null타입에러를 모두 해결한다. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiende74
changed the title
healim01
reviewed
Aug 3, 2024
Comment on lines
+26
to
+28
| <FaceMark.FaceIcon emotion={grade} isFilled={true} /> | ||
| {/* TODO : 기존에 null 체크 안되고있었음. 일단 SOSO로 해뒀으나 미입력시의 아이콘으로 수정필요 */} | ||
| <FaceMark.Footer>{emotionPhrase[grade ?? 'SOSO']}</FaceMark.Footer> |
There was a problem hiding this comment.
기존 null 체크를 해서 null 일 때 SOSO 가 될 수 있도록 작업되어있던거 같은데 아닌가요?
There was a problem hiding this comment.
기존엔 'null'의 string일때 SOSO그림을 보여주도록 작업되어 있는데
실제들어가는건 null 타입이라 타입에러가 뜬 것 같네요.
healim01
reviewed
Aug 3, 2024
| GOOD: '좋아요', | ||
| null: '-', | ||
| }; | ||
| export const emotionPhrase = { BAD: '별로에요', SOSO: '평범해요', GOOD: '좋아요' }; |
There was a problem hiding this comment.
이 부분 변경을 리안이 진행해서 conflict 이 뜰거 같네요
There was a problem hiding this comment.
타입에러 고친게 많은데, 리안 작업이 먼저들어와서 conflict가 많이 뜰 거라
그냥 리안거 머지하면 사실상 새로 해서 다시올려야 될 것 같다고 생각되네요.
skiende74
changed the title
|
conflicts이 어마무시하게 뜨네열,,, 수정 후 머지하시면 될거 같습니다 |
|
리안이랑 커밋이 많이 겹쳐서 그냥 리안에게 PR을 통해 null 타입에러를 처리하도록 전달하였고 이 PR에서 반영했던 type관련사항은 새 PR에서 다시처리하는게 나을거같습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
타입체크들 잡느라 여러파일이 건드려져서 FileChanges는 많지만 커밋은 적습니다.
tsconfig strict의 strict 모드가 켜져야 null 에러가 안쌓여서
빠른 merge 부탁드립니다.
🎸 기타