[BE] 회원가입/로그인 후 토큰을 반환한다. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/bang-ggood/src/main/java/com/bang_ggood/exception/ExceptionCode.java
# Conflicts: # backend/bang-ggood/src/main/java/com/bang_ggood/exception/ExceptionCode.java
# Conflicts: # backend/bang-ggood/src/main/java/com/bang_ggood/user/controller/UserController.java # backend/bang-ggood/src/main/java/com/bang_ggood/user/dto/request/OauthLoginRequest.java # backend/bang-ggood/src/main/java/com/bang_ggood/user/dto/response/OauthInfoResponse.java # backend/bang-ggood/src/main/java/com/bang_ggood/user/service/UserService.java
JINU-CHANG
requested review from
tsulocalize,
shin-jisong and
tkdgur0906
and removed request for
shin-jisong
JINU-CHANG
requested review from
shin-jisong
and removed request for
shin-jisong
tkdgur0906
requested changes
Aug 3, 2024
| import org.springframework.data.jpa.repository.config.EnableJpaAuditing; | ||
|
|
||
| @ConfigurationPropertiesScan |
There was a problem hiding this comment.
ConfigurationProperties를 쓰는 부분이 있나요?
따로 이 어노테이션을 추가하신 이유가 있을까요?
There was a problem hiding this comment.
헉 ..! 저번 리뷰 반영하다 들어간 것 같네요 삭제하겠습니다!!
| @Test | ||
| void login_signup() { | ||
| // given | ||
| Mockito.when(oauthClient.requestOauthInfo(new OauthLoginRequest(""))) |
There was a problem hiding this comment.
OauthLoginRequest 도 Fixture로 분리하는 건 어떤가요?
불필요하다 생각하면 유지하셔도 좋습니다!
tkdgur0906
approved these changes
Aug 3, 2024
tsulocalize
requested changes
Aug 3, 2024
backend/bang-ggood/src/main/java/com/bang_ggood/user/domain/User.java
Outdated
Show resolved
Hide resolved
backend/bang-ggood/src/main/java/com/bang_ggood/user/dto/response/OauthInfoResponse.java
Outdated
Show resolved
Hide resolved
backend/bang-ggood/src/test/java/com/bang_ggood/user/service/JwtTokenProviderTest.java
Outdated
Show resolved
Hide resolved
shin-jisong
reviewed
Aug 5, 2024
backend/bang-ggood/src/main/java/com/bang_ggood/category/service/CategoryService.java
Show resolved
Hide resolved
backend/bang-ggood/src/main/java/com/bang_ggood/user/controller/UserController.java
Show resolved
Hide resolved
backend/bang-ggood/src/test/java/com/bang_ggood/AcceptanceMockTestSupport.java
Outdated
Show resolved
Hide resolved
backend/bang-ggood/src/test/java/com/bang_ggood/checklist/ChecklistFixture.java
Show resolved
Hide resolved
backend/bang-ggood/src/test/java/com/bang_ggood/checklist/service/ChecklistServiceTest.java
Show resolved
Hide resolved
backend/bang-ggood/src/test/java/com/bang_ggood/user/UserFixture.java
Outdated
Show resolved
Hide resolved
backend/bang-ggood/src/test/java/com/bang_ggood/user/controller/LoginMockE2ETest.java
Show resolved
Hide resolved
shin-jisong
requested changes
Aug 5, 2024
tsulocalize
approved these changes
Aug 5, 2024
shin-jisong
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타