[BE] 카테고리 버그 수정 #1123
Open
[BE] 카테고리 버그 수정 #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddevilmidzy
approved these changes
Feb 12, 2025
| @@ -59,7 +58,6 @@ void show_category() { | |||
| .statusCode(200); | |||
| } | |||
|
|
|||
| @Disabled | |||
There was a problem hiding this comment.
테스트 코드도 다시 손좀 봐줘야할텐데 다음 오프때는 테스트코드도 건들여보죠
Comment on lines
+67
to
69
| final Category category = new Category(request.value()); | ||
| categoryEntity.updateCategoryName(category); | ||
| return new CategoryUpdateResponse(categoryEntity.getCategoryName()); |
There was a problem hiding this comment.
아래 리턴에는 request.value()로 안바꿔줘도 되는건가요? 리턴값은 사용하지 않아서 상관 없으려나요
There was a problem hiding this comment.
이번 PR 내용이 별로 없어 이해가 안되실것 같아 PR 상세 설명에 �버그 픽스 내용 적어놓을게요
일단 리턴값은 지금 상태가 맞습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
상세 설명
이전 PR(#1116)에서 카테고리 이름을 수정할때,
수정할 카테고리 이름의 길이를 검증하고자 new Category(수정할 카테고리 이름)를 추가해야 하는데
실수로 new Category(기존 카테고리 이름) 으로 코드를 작성했습니다.
new Category(수정할 카테고리 이름) 안에서 수정할 카테고리 이름에 대한 길이 검증을 하고 있습니다.