chore-fe: Question 타입 Description 추가 및 이에 따른 생성 구현에 대한 로직 수정 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
chore
|
1738036875.183899 |
lurgi
changed the title
|
1738036972.422649 |
llqqssttyy
approved these changes
Jan 31, 2025
Comment on lines
+111
to
+117
| <TextField | ||
| placeholder="질문 설명을 입력하세요." | ||
| onChange={handleChangeDescription} | ||
| maxLength={300} | ||
| value={description} | ||
| isLengthVisible | ||
| /> |
There was a problem hiding this comment.
[제안]
현재는 텍스트 필드의 크기를 변경하면 레이아웃이 깨질 수 밖에 없네요.
개선을 위해서는
- TextField의 resize 옵션에 'horizontal'을 전달하는 방법
- resize를 false로 전달하고, TextField의 너비, 높이가 부모 요소를 따르도록 변경하는 방법
정도가 생각나네요.
하지만 굳이 고칠 필요 없다 생각되시면 넘어가주세요~
There was a problem hiding this comment.
TextArea 코드 살펴보니 설계의도가 파악되네요. 어떤 말씀하시는지 대강 알겠습니다!
해당 TextArea를 감싸는 container는 flex, direction column으로 동작해서 width 100%처럼 동작하기 때문에 문제될 것은 없다고 생각되네요!
lurgi
added a commit
that referenced
this pull request
Feb 10, 2025
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
작업 세부사항
참고사항
closes #1002