♻️ change user api #110
Merged
♻️ change user api #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
geoje
approved these changes
Jul 28, 2024
| @@ -31,7 +31,7 @@ public GoogleLoginResponse loginWithGoogle(GoogleLoginRequest googleLoginRequest | |||
| if (!userRepository.existsByEmail(email)) { | |||
| return new GoogleLoginResponse(false, null); | |||
| } | |||
| User user = userRepository.findByEmail(email); | |||
| User user = userRepository.findByEmail(email).orElseThrow(); | |||
There was a problem hiding this comment.
Optional 사용은 탁월한 선택이에요!
위쪽에서 existsByEmail 을 함으로써 아래쪽의 Optional`은 Not Null 이라는게 자명하긴 합니다.
하지만 굳이 비슷한 쿼리가 2번 발생할 필요가 있을지 의문이에요!
최초의 로그인에만 필요한 부분이니 큰 리소스 낭비가 없다고 판단 되면 굳이 합칠 필요는 없어 보여요.
There was a problem hiding this comment.
좋은 지적입니다!
public GoogleLoginResponse loginWithGoogle(GoogleLoginRequest googleLoginRequest) {
FirebaseToken decodedToken = decodeIdToken(googleLoginRequest.idToken());
String email = decodedToken.getEmail();
User user = userRepository.findByEmail(email).orElse(null);
if (user == null) {
return new GoogleLoginResponse(false, null);
}
String accessToken = jwtTokenManager.createToken(new TokenPayload(user.getId(), user.getEmail()));
return new GoogleLoginResponse(true, accessToken);이 방법을 고민하고 있었어요.
말씀해주신대로 쿼리가 한번만 나가게 수정후 배포하겠습니다!
| @@ -42,7 +48,8 @@ void getUserById() { | |||
|
|
|||
| UserResponse actual = RestAssured.given().log().all() | |||
| .contentType(ContentType.JSON) | |||
| .when().get("/api/user/" + id) | |||
| .header("Authorization", "Bearer " + accessToken) | |||
| .when().get("/api/user/me") | |||
tackyu
approved these changes
Jul 28, 2024
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
잘못 설계했던 api를 변경했습니다.
기존 :
api/user/{{id}}변경 :
api/user/me