-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ change version of user comment list #433
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,7 +177,7 @@ void deleteCommentWhenNotCommentOwner() { | |
@Test | ||
@WithLoginUser(email = "[email protected]") | ||
@DisplayName("로그인한 사용자의 댓글을 조회한다.") | ||
void readCommentsOfUser() { | ||
void readCommentsOfUserV1() { | ||
RestAssured.given(spec).log().all() | ||
.filter(document(DEFAULT_RESTDOCS_PATH, | ||
"로그인한 사용자의 댓글을 조회합니다.", | ||
|
@@ -190,6 +190,7 @@ void readCommentsOfUser() { | |
fieldWithPath("[].createdAt").description("작성 시간"), | ||
fieldWithPath("[].message").description("내용") | ||
))) | ||
.accept("application/vnd.pengcook.v1+json") | ||
.when().get("/comments/mine") | ||
.then().log().all() | ||
.body("size()", is(COMMENT_COUNT_OF_LOKI)); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 리뷰 보다는 생각해볼만한 거리인것 같은데 추후에도 계속 모든 메서드에 버전이 추가되면 항상
produces = "application/vnd.pengcook.v1+json
이 반복되게 될것 같아 나중에 불편하지 않을까 생각이 들었어요. 다음 회의때 같이 고민해보면 좋지 않을까 생각합니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞는 말이네요. 작성도 불편하고 확인도 불편하겠어요!
회의록을 미리 만들어서 의견 업로드 해뒀습니다~
다음 회의 때 같이 이야기해보아요.