♻️ separate recipe info query #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- retrieve category and ingredient from respective services - move DTOs to respective domains
|
tackyu
approved these changes
Dec 24, 2024
Comment on lines
37
to
38
|
|
||
| public List<IngredientResponse> findIngredientByRecipe(Recipe recipe) { |
There was a problem hiding this comment.
@Transactional(readOnly = true)을 안붙이신 이유가 있으신가요??
| @@ -32,6 +35,13 @@ public void register(List<IngredientCreateRequest> requests, Recipe recipe) { | |||
| } | |||
| } | |||
|
|
|||
| public List<IngredientResponse> findIngredientByRecipe(Recipe recipe) { | |||
| return ingredientRecipeRepository.findAllByRecipeId(recipe.getId()) | |||
There was a problem hiding this comment.
categoryRecipeRepository.findAllByRecipe(recipe);
엔티티로 조회할지 id로 조회할지 얘기해보면 좋을 것 같아요!
There was a problem hiding this comment.
크게 문제가 될것 같지는 않지만 다른 로직에서 대부분 아이디로 조회하고 있네요. 수정하는것도 좋아 보입니다!
There was a problem hiding this comment.
일단 카테고리를 먼저 수정했는데 카테고리엔 관련 메서드가 없어서 새로 만들었습니다!
그런데 재료에는 관련 메서드가 있어서 일단 그걸 먼저 사용했어요.
이따 회의 때 카테고리의 메서드도 통일하는게 좋을지 함께 이야기해보아요...!!
Comment on lines
12
to
13
| ingredientRecipe.getRequirement()) | ||
| ; |
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ
고치겠습니다................ ㅎㅎ
Comment on lines
28
to
33
| public RecipeDescriptionResponse( | ||
| UserInfo userInfo, | ||
| RecipeDataResponse firstResponse, | ||
| Recipe recipe, | ||
| List<CategoryResponse> category, | ||
| List<IngredientResponse> ingredient, | ||
| boolean isLike |
HaiSeong
approved these changes
Dec 26, 2024
| @@ -32,6 +35,13 @@ public void register(List<IngredientCreateRequest> requests, Recipe recipe) { | |||
| } | |||
| } | |||
|
|
|||
| public List<IngredientResponse> findIngredientByRecipe(Recipe recipe) { | |||
| return ingredientRecipeRepository.findAllByRecipeId(recipe.getId()) | |||
There was a problem hiding this comment.
크게 문제가 될것 같지는 않지만 다른 로직에서 대부분 아이디로 조회하고 있네요. 수정하는것도 좋아 보입니다!
Comment on lines
-45
to
+48
| userInfo.isSameUser(firstResponse.authorId()), | ||
| userInfo.isSameUser(recipe.getAuthor().getId()), |
Comment on lines
-97
to
-103
| @Query(""" | ||
| SELECT new net.pengcook.recipe.dto.RecipeDataResponse( | ||
| r.id, | ||
| r.title, | ||
| r.author.id, | ||
| r.author.username, | ||
| r.author.image, |
|
|
- modify considering meaning and JPA usage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
레시피의 정보를 찾아올 때, 조인을 남발하고 한방 쿼리로 찾아오던 것을 변경했습니다.
카테고리는 카테고리서비스에서, 재료는 재료서비스에서 찾아옵니다.
그리고 그것들을 레시피서비스에서 합칩니다!
주된 변경은 레시피서비스이니 그 부분을 시작으로 확인하시면 읽기 편할 겁니다!