♻ remove unnecessary JPQL #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
|
hyxrxn
requested review from
tackyu and
HaiSeong
and removed request for
HaiSeong
HaiSeong
reviewed
Mar 3, 2025
| FROM Recipe r | ||
| WHERE r.author.id = :userId | ||
| """) | ||
| List<Long> findRecipeIdsByUserId(long userId); |
Comment on lines
+14
to
18
| SELECT recipe | ||
| FROM CategoryRecipe | ||
| WHERE category.name = :category | ||
| ORDER BY recipe.createdAt DESC | ||
| """) |
There was a problem hiding this comment.
이 쿼리 자체는 지울수 없을요?
네임드 쿼리로 변경 가능할 것 같은데 확인 해주실 수 있나요
There was a problem hiding this comment.
드라이빙 테이블을 CategoryRecipe로 바꾸고 싶어서 쿼리를 직접 쓴거기도 하고, Recipe가 Category를 들고있지 않아서 불가능합니다!
RecipeRepository 말고 CategoryRepository에서 실행하면 CategoryRecipe 객체 리스트를 리턴하게 해서 가능합니다.
tackyu
approved these changes
Mar 4, 2025
| @@ -20,49 +20,53 @@ class RecipeRepositoryTest { | |||
| private RecipeRepository repository; | |||
|
|
|||
| @Test | |||
| @DisplayName("요청한 페이지에 카테고리 이름으로 레시피 id 목록을 반환한다.") | |||
| @DisplayName("요청한 페이지에 카테고리 이름으로 레시피 목록을 반환한다.") | |||
| void findRecipeIdsByCategory() { | |||
There was a problem hiding this comment.
테스트코드 메서드 명을 같이 수정해도 좋을 것 같아요
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제가
findRecipeDataV1없애는거 따로,findAllByAuthorId로 JPA 사용하게 바꾸는거 따로 커밋을 했거든요...풀땡기니까 폰드꺼랑 컨플릭트나서 여차저차 해결했더니... PR 창에서 여전히 컨플릭트때문에 머지 못한다고 하더라고요?
그래서 rebase하면서 다시 해결했더니 커밋이 하나가 되었네요....;;
알아보기 힘드시면 브랜치 새로 파서 금방 다시 올리겠습니다 ㅋㅋ ㅜㅜ
의견 주십쇼,,,
+) 아이디 대신 도메인 리턴하도록 변경한 커밋도 추가했습니다~~ 충돌이 안나니까 눈물이 다 나네요
closes #456