-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5기] 4주차 쇼핑몰 과제 제출 - 딱구 #2
Open
SeolYoungKim
wants to merge
52
commits into
woowahan-pjs:main
Choose a base branch
from
SeolYoungKim:seolyoungkim
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ( ) [ ] + - & / _ 만 사용 가능하다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4주차 미션 제출합니다.
간단해보였는데 간단하지 않았네요..!
최대한 외부 의존성을 추가하지 않고 간단하게 구현하는 것이 목표였습니다.
기능을 구현하고 테스트까지 욕심 내봤는데, 외부 API가 있을 때에 대한 테스트를 작성하는 방법을 찾는 데 꽤나 오래걸렸네요 ㅠ
제한 사항이나 추가적으로 도출할만한 요구사항은 꾸준히 추가해보려고합니다..