Fix issue when removing media in the middle of a paragraph #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo04
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Hi @planarvoid, thank you for the fix. I tested different escenarios around galleries and other placeholders and everything is working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This PR fixes a crash that's happening when a media item is removed in the middle of a paragraph. The fix is to ignore the spans that are wrapping the media, only to handle the ones starting right after the media end.
Test
PARAGRAPH span must start at paragraph boundaryexceptionReview
@danilo04
Make sure strings will be translated:
strings.xmlas a part of the integration PR.