Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redrawViews method to PlaceholderManager #1093

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add redrawViews method to PlaceholderManager #1093

merged 1 commit into from
Nov 14, 2024

Conversation

planarvoid
Copy link
Contributor

Fix

In order to redraw placeholder manager from a composable we need to extract the redrawViews method.

Test

  1. Test with the related DO PR

Review

@danilo04

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

danilo04
danilo04 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@danilo04 danilo04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does redraw when it is called (e.g. when device is rotated).

@danilo04 danilo04 merged commit 806c3a4 into trunk Nov 14, 2024
14 checks passed
@danilo04 danilo04 deleted the add-redraw-placeholder-method branch November 14, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo04 danilo04 danilo04 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planarvoid @danilo04