Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Samsung predictive text in the Aztec editor #21740

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Mar 7, 2025

Fixes #21739

Support ticket: 9482638-zd-a8c
Slack discussion: p1741286044939189-slack-C04PWEZSYFL

A user reported that changing links in their post in the Android app caused images to be replaced with [OBJ] blocks. We were unable to reproduce the issue on Pixel devices, but we were able to reproduce it on a Samsung device.

We then discovered that this exact issue has occurred before, and the proposed solution was to use AztecText.enableSamsungPredictiveBehaviorOverride to disable predictive text on Samsung devices running API 33+. This PR adds this solution.

To test:

  • Follow the instructions at P9ugOq-4rN-p2 to create a post that will enable the Aztec editor on Android
  • Add at least one image to the post and make the text long enough that the image can be scrolled offscreen in the app
  • In trunk, open the post in a Samsung device using the Samsung keyboard, scroll down past the image, and modify the text (note the user reported that adding a hyperlink caused the issue)
  • Note the image is replaced by [OBJ]
  • Do the same with this branch and note the image is not replaced

@nbradbury nbradbury added the Aztec label Mar 7, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 7, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 7, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21740-143a178
Commit143a178
Direct Downloadwordpress-prototype-build-pr21740-143a178.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 7, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21740-143a178
Commit143a178
Direct Downloadjetpack-prototype-build-pr21740-143a178.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.41%. Comparing base (8e04313) to head (143a178).

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21740   +/-   ##
=======================================
  Coverage   39.41%   39.41%           
=======================================
  Files        2122     2122           
  Lines       99570    99570           
  Branches    15324    15324           
=======================================
  Hits        39247    39247           
  Misses      56844    56844           
  Partials     3479     3479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nbradbury nbradbury marked this pull request as ready for review March 10, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aztec issues with Samsung predictive text
3 participants