-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WordPressKit as a binary framework #23418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
kean
force-pushed
the
task/remove-wpkit-package
branch
from
July 13, 2024 01:15
55a5732
to
61dac1a
Compare
kean
changed the title
[Experimental] WordPressKit binary framework
WordPressKit as a binary framework
Jul 13, 2024
kean
force-pushed
the
task/remove-wpkit-package
branch
from
July 13, 2024 01:28
61dac1a
to
69e3c05
Compare
jkmassel
approved these changes
Jul 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WordPressKit
using SwiftPM and remove the code from the repowpxmlrpc
dependency from the appNSObject-SafeExpectations
dependency fromWordPressAuthentificator
WordPressKit
can now be used as a dependency for any of the internal packages we introduce.WordPressAuthentificator
now also has a path to becoming a SwiftPM module.It also slightly reduces the build time: 103 sec → 94 sec (-9 sec or nearly 9%). It is a bit hard to measure accurately, so take it with a grain of salt.
Related PR: wordpress-mobile/WordPressKit-iOS#816
Remainig steps:
The app already runs, but just to be safe, we need to ensure that the Objective-C dependencies that are currently linked statically in
WordPressKit
do not create any ambiguity in the Objective-C runtime. I achieved that withWordPressShared
by inlining its sources inWordPressKit
and prefixing the Objective-C methods withwpkit_
.wpxmlrpc
usages from the app to make sure there is no runtime ambiguous – I already done it before in Remove direct wpxmlrpc usages from the app #23389To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: