Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftSoup to address privacy manifest warning #23551

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

spencertransier
Copy link
Contributor

We received the following email from Apple after the 25.3.0.1 build was uploaded to App Store Connect today:

We noticed one or more issues with a recent submission for App Store review for the following app:

WordPress – Website Builder
Version 25.3
Build 25.3.0.1
Although submission for App Store review was successful, you may want to correct the following issues in your next submission for App Store review. Once you've corrected the issues, upload a new binary to App Store Connect.

ITMS-91108: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “SwiftSoup_SwiftSoup.bundle/PrivacyInfo.xcprivacy”. In addition to the privacy manifest files in the locations outlined in the documentation, starting November 12, 2024, all privacy manifests you submit must have valid content. Keys and values in any privacy manifest must be in a valid format. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files and https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/adding_a_privacy_manifest_to_your_app_or_third-party_sdk.

Apple Developer Relations

The version of SwiftSoup currently being used is 2.7.1, which was released on February 15, 2024. A fix for the privacy manifest was merged on March 18, 2024. This PR updates SwiftSoup to the latest version, 2.7.5, so that the updated privacy manifest will be included with the next upload.

To test:

Regression Notes

  1. Potential unintended areas of impact
    I am not familiar with the areas of the app that could be affected by upgrading SwiftSoup.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I would love some help from the reviewer to know whether this upgrade could have unintended consequences within the app.

  3. What automated tests I added (or what prevented me from doing so)
    None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@spencertransier spencertransier added the dependencies Pull requests that update a dependency file label Sep 4, 2024
@spencertransier spencertransier added this to the 25.4 milestone Sep 4, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23551-9b3106d
Version25.3
Bundle IDorg.wordpress.alpha
Commit9b3106d
App Center BuildWPiOS - One-Offs #10582
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23551-9b3106d
Version25.3
Bundle IDcom.jetpack.alpha
Commit9b3106d
App Center Buildjetpack-installable-builds #9624
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@crazytonyli crazytonyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade!

@spencertransier spencertransier added this pull request to the merge queue Sep 4, 2024
Merged via the queue into trunk with commit 7557830 Sep 4, 2024
25 checks passed
@spencertransier spencertransier deleted the update/swift-soup branch September 4, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants