Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Presentation Enhancements #23702

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Open

Conversation

jkmassel
Copy link
Contributor

A few small fixes – each commit explains itself

@jkmassel jkmassel added this to the 25.5 milestone Oct 25, 2024
@jkmassel jkmassel self-assigned this Oct 25, 2024
@jkmassel jkmassel marked this pull request as ready for review October 25, 2024 17:18
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23702-33eb800
Version25.4
Bundle IDorg.wordpress.alpha
Commit33eb800
App Center BuildWPiOS - One-Offs #10868
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23702-33eb800
Version25.4
Bundle IDcom.jetpack.alpha
Commit33eb800
App Center Buildjetpack-installable-builds #9909
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@@ -17,6 +20,7 @@ struct WordPressDotComAuthenticator {
case parsing(DecodingError)
case cancelled
case unknown(Swift.Error)
case unableToStartLoginSession
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any code that throws this new error.

Base automatically changed from task/wpcom-web-based-authentication-rollout to trunk November 3, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants