Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WKWebView retain cycle in Reader #24028

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 29, 2025

Fixes #

To test:

  • I checked that ReaderWebViewMessageHandler gets called and ReaderWebView deinit also does

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 25.7 ❄️ milestone Jan 29, 2025
@kean kean requested a review from crazytonyli January 29, 2025 22:25
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 25.7 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.
1 Message
📖 This PR contains changes to RELEASE-NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 Danger

@kean kean enabled auto-merge (squash) January 29, 2025 22:29
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24028-035b0de
Version25.7
Bundle IDorg.wordpress.alpha
Commit035b0de
App Center BuildWPiOS - One-Offs #11422
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24028-035b0de
Version25.7
Bundle IDcom.jetpack.alpha
Commit035b0de
App Center Buildjetpack-installable-builds #10455
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit 50088df into release/25.7 Jan 29, 2025
25 checks passed
@kean kean deleted the fix/retain-cycle-reader branch January 29, 2025 23:41
oguzkocer pushed a commit that referenced this pull request Jan 30, 2025
* Fix WKWebView retain cycles in Reader

* Update release notes
github-merge-queue bot pushed a commit that referenced this pull request Jan 30, 2025
* Fix WKWebView retain cycle in Reader (#24028)

* Fix WKWebView retain cycles in Reader

* Update release notes

* Update app translations – `Localizable.strings`

* Update WordPress metadata translations

* Update Jetpack metadata translations

* Bump version number

---------

Co-authored-by: Alex Grebenyuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants