Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM Prep – Define new CoreAPI package #782

Merged
merged 12 commits into from
Apr 16, 2024
Merged

SPM Prep – Define new CoreAPI package #782

merged 12 commits into from
Apr 16, 2024

Commits on Apr 12, 2024

  1. Define new CoreAPI package — Currently only WordPressAPIError in it

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0412d8d View commit details
    Browse the repository at this point in the history

  2. Move a couple more files

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    70b798c View commit details
    Browse the repository at this point in the history

  3. Update SwiftLint config to ignore .build from SPM

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    61a40e1 View commit details
    Browse the repository at this point in the history

  4. Move all remaining source files

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b87c4c0 View commit details
    Browse the repository at this point in the history

  5. Comment all WPKitLog* usages in CoreAPI to get to build

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    576a820 View commit details
    Browse the repository at this point in the history

  6. Move remaining tests to CoreAPITests/

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    dac09cd View commit details
    Browse the repository at this point in the history

  7. Move fixtures to CoreAPITests

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    dbd8322 View commit details
    Browse the repository at this point in the history

  8. Move ServiceRemoteWordPressComREST to new BasicBlogAPIObjc/

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    281cf4b View commit details
    Browse the repository at this point in the history

  9. Extract logic to compute REST path with version

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d1c738c View commit details
    Browse the repository at this point in the history

  10. Move WordPressComRESTAPIVersionedPathBuilder to APIInterface/

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    46e3a5f View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Add SPM-ok imports in WordPressComRESTAPIVersionedPathBuilder

    @mokagio
    mokagio committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7198442 View commit details
    Browse the repository at this point in the history

  2. Move WordPressComRestApiErrorDomain to APIInterface 

    This DRYs the definition, makes the constant available to both
Objective-C and Swift, and removes the need for custom builder and
checker.

See @crazytonyli's suggestion from
#782 (comment)
    @mokagio
    mokagio committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6fba3a1 View commit details
    Browse the repository at this point in the history