Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout grid - Fix placeholder styles #6014

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Layout grid - Fix placeholder styles #6014

merged 2 commits into from
Aug 3, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Aug 1, 2023 •
edited
Loading

Related PRs:

Fixes an issue with the placeholder styles after the recent design changes related to block outlines for selected/unselected states.

To test:

  • Open the app using the host apps or from this iOS build
  • Add a Layout grid block
  • Expect to see the "Select a layout" picker
  • Tap on any of the options
  • Expect to see the picker to be dismissed and the block to show the selected outline
After
LayoutGrid.mov

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added bugfix Layout Block Issues related to the mobile layour grid block labels Aug 1, 2023
@geriux geriux requested a review from derekblank August 1, 2023 14:37
@geriux geriux marked this pull request as ready for review August 1, 2023 14:37
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

2 similar comments
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux
Copy link
Contributor Author

geriux commented Aug 2, 2023

Hey @derekblank 👋 I've merged the companion PR and updated the block-experiments reference, could you review this PR as well? Thank you!

derekblank
derekblank approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Automattic/block-experiments#335 (review) 🚀

@geriux geriux merged commit c4ec0e1 into trunk Aug 3, 2023
@geriux geriux deleted the fix-layout-grid-placeholder branch August 3, 2023 07:24
@geriux geriux added this to the 1.101.0 (23.0) milestone Aug 3, 2023
@geriux geriux self-assigned this Aug 3, 2023
@geriux geriux mentioned this pull request Aug 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekblank derekblank derekblank approved these changes

Assignees

@geriux geriux

Labels
bugfix Layout Block Issues related to the mobile layour grid block
Projects
None yet
Milestone
1.101.0 (23.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @derekblank