Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup frontend #272

Closed
26 tasks done
Zoe-Bot opened this issue Jan 30, 2023 · 9 comments · Fixed by #425
Closed
26 tasks done

Cleanup frontend #272

Zoe-Bot opened this issue Jan 30, 2023 · 9 comments · Fixed by #425
Assignees
Labels
frontend improvement Improvements to a existing feature.
Milestone

Comments

@Zoe-Bot
Copy link
Contributor

Zoe-Bot commented Jan 30, 2023

  • types cleanup (check for any (FieldProps))
  • Einheitliches Formatting
  • remove cypress/support and all .cy.ts/.cy.tsx/*.unit.ts from code coverage
  • image in correct folder

Done:

  • update all yup validations imports
  • update all component tests das alle wrapper und onsubmits einheitlich sind
  • Remove all console.logs
  • swap all titles with tooltips
  • Add comments for next/babel error Tailwind config "Cannot find module 'next/babel' #190
  • remove unit in utils
  • packages update
  • commented code cleanup
  • remove all todos in code
  • duplicate code check (especially routes)
  • architectur check
  • remove all loading...
  • add comments
  • Update test fixtures
  • Ensure to have "const x = () =>" instead of function style everywhere we do not require "this" keyword.
  • check all spaces in all files to be 4
  • tests all method parameters should be objects (like mockprofilepage command)
  • Update all types to be correct
  • Check all validations for fields are correct (min, max strings,..)
  • Check reloading in tabs.cy.ts
  • Remove deps from tests (tabs.cy.ts uses router to generate url. The test fails when the router is not working... Remove this deps)
  • rename variables, functions,..
@Zoe-Bot Zoe-Bot added enhancement New feature or request frontend labels Jan 30, 2023
@Zoe-Bot Zoe-Bot added this to the Sprint 5 milestone Jan 30, 2023
This was referenced Feb 2, 2023
@Zoe-Bot Zoe-Bot modified the milestones: Sprint 5, Sprint 6 Feb 14, 2023
@LarsFlieger

This comment was marked as resolved.

@Branchverse

This comment was marked as resolved.

@Branchverse

This comment was marked as resolved.

@Branchverse

This comment was marked as resolved.

@Branchverse

This comment was marked as resolved.

@Branchverse

This comment was marked as resolved.

@Branchverse

This comment was marked as resolved.

@Branchverse

This comment was marked as resolved.

@Zoe-Bot Zoe-Bot added improvement Improvements to a existing feature. and removed enhancement New feature or request labels Feb 16, 2023
@LarsFlieger

This comment was marked as resolved.

@Zoe-Bot Zoe-Bot linked a pull request Feb 18, 2023 that will close this issue
@Zoe-Bot Zoe-Bot removed a link to a pull request Feb 18, 2023
@Zoe-Bot Zoe-Bot linked a pull request Feb 18, 2023 that will close this issue
@Zoe-Bot Zoe-Bot removed a link to a pull request Feb 18, 2023
@Zoe-Bot Zoe-Bot linked a pull request Feb 19, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend improvement Improvements to a existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants