Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/260 checkbox component #262

Merged
merged 9 commits into from
Feb 2, 2023
Merged

Conversation

Zoe-Bot
Copy link
Contributor

@Zoe-Bot Zoe-Bot commented Jan 29, 2023

Close #260

@Zoe-Bot Zoe-Bot added this to the Sprint 5 milestone Jan 29, 2023
@Zoe-Bot Zoe-Bot requested a review from LarsFlieger January 29, 2023 20:05
@Zoe-Bot Zoe-Bot self-assigned this Jan 29, 2023
@Zoe-Bot Zoe-Bot linked an issue Jan 29, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@LarsFlieger LarsFlieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zoe-Bot Zoe-Bot requested a review from LarsFlieger January 31, 2023 20:01
@Zoe-Bot
Copy link
Contributor Author

Zoe-Bot commented Jan 31, 2023

Done @LarsFlieger

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 95.22% // Head: 95.22% // No change to project coverage 👍

Coverage data is based on head (41d7625) compared to base (b1b014a).
Patch has no changes to coverable lines.

❗ Current head 41d7625 differs from pull request most recent head b91f009. Consider uploading reports for the commit b91f009 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          33       33           
  Lines         335      335           
  Branches       24       24           
=======================================
  Hits          319      319           
  Misses         16       16           
Flag Coverage Δ
query-backend 95.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@LarsFlieger LarsFlieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Mir ist noch eine wichtige Sachen aufgefallen (helperText condition) sonst ist alles gut :) Idee für noch einen Test aber kann verschoben werden. Aber ist vllt ne gute Idee für a11y zu testen :)

Copy link
Contributor

@LarsFlieger LarsFlieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LarsFlieger
Copy link
Contributor

@Zoe-Bot Please merge. Bug is noticed in #272

@Zoe-Bot Zoe-Bot merged commit c4529b7 into main Feb 2, 2023
@Zoe-Bot Zoe-Bot deleted the feature/260-checkbox-component branch February 2, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox Component
2 participants