-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/260 checkbox component #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Ensure that people understand that it's multiple checkboxes (e.g for name: CheckboxList)
- Wait for: https://stackoverflow.com/questions/75299436/how-to-create-a-typescript-type-for-an-array-with-unique-properties-for-one-key and ensure that type is unique when possible
- Add cursor on checkbox hover
Add cursor pointer to checkbox
Done @LarsFlieger |
Codecov ReportBase: 95.22% // Head: 95.22% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 33 33
Lines 335 335
Branches 24 24
=======================================
Hits 319 319
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Mir ist noch eine wichtige Sachen aufgefallen (helperText condition) sonst ist alles gut :) Idee für noch einen Test aber kann verschoben werden. Aber ist vllt ne gute Idee für a11y zu testen :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…e-weights/wwweights into feature/260-checkbox-component
Close #260