Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/229 connect unitconverter to frontend #302

Merged
merged 11 commits into from
Feb 8, 2023

Conversation

LarsFlieger
Copy link
Contributor

@LarsFlieger LarsFlieger commented Feb 5, 2023

Close #251
Close #229

@LarsFlieger LarsFlieger linked an issue Feb 5, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 90.27% // Head: 87.64% // Decreases project coverage by -2.64% ⚠️

Coverage data is based on head (3b409ce) compared to base (af4fc89).
Patch has no changes to coverable lines.

❗ Current head 3b409ce differs from pull request most recent head 2109380. Consider uploading reports for the commit 2109380 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   90.27%   87.64%   -2.64%     
==========================================
  Files          52       25      -27     
  Lines         658      356     -302     
  Branches       44       28      -16     
==========================================
- Hits          594      312     -282     
+ Misses         64       44      -20     
Flag Coverage Δ
auth-backend ?
command-backend 87.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/auth/src/db/ user.service.ts
backend/auth/src/profile/profile.controller.ts
backend/auth/src/db/db.module.ts
backend/auth/test/helpers/typeOrmSetup.ts
backend/auth/test/helpers/general.helper.ts
backend/auth/src/shared/enums/status.enum.ts
backend/auth/src/app.service.ts
backend/auth/src/auth/auth.controller.ts
backend/auth/src/profile/profile.module.ts
backend/auth/src/auth/dtos/login.dto.ts
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LarsFlieger LarsFlieger marked this pull request as draft February 5, 2023 15:21
@mlp909 mlp909 marked this pull request as ready for review February 6, 2023 13:52
@mlp909
Copy link
Contributor

mlp909 commented Feb 6, 2023

Alle Gewichte sind mit der unitconverter Funktion verbunden.
Es wird auf drei Nachkommastellen gerundet --> Siehe #308

@mlp909 mlp909 requested a review from Zoe-Bot February 6, 2023 13:58
@mlp909 mlp909 self-assigned this Feb 6, 2023
Copy link
Contributor

@Zoe-Bot Zoe-Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus. Zwei Sachen

@mlp909
Copy link
Contributor

mlp909 commented Feb 7, 2023

Sieht gut aus. Zwei Sachen

Du wolltest doch, dass das ein Punkt ist, davor war es ein Komma. :D
Aber wie in dem Link, den du geschickt hast, ist das hier ja 2018 g also in deutscher Schreibweise 2,018 kg und in der US-Schreibweise, die du haben wolltest, sind es doch dann wie oben 2.018 oder?

@mlp909 mlp909 requested a review from Zoe-Bot February 7, 2023 11:53
@mlp909 mlp909 added the frontend label Feb 7, 2023
@mlp909 mlp909 added this to the Sprint 5 milestone Feb 7, 2023
@Zoe-Bot
Copy link
Contributor

Zoe-Bot commented Feb 7, 2023

Sieht gut aus. Zwei Sachen

Du wolltest doch, dass das ein Punkt ist, davor war es ein Komma. :D Aber wie in dem Link, den du geschickt hast, ist das hier ja 2018 g also in deutscher Schreibweise 2,018 kg und in der US-Schreibweise, die du haben wolltest, sind es doch dann wie oben 2.018 oder?

Ja ist richtig so hab vercheckt das das kg sind dachte irgendwie das sind g

Copy link
Contributor

@Zoe-Bot Zoe-Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mlp909 mlp909 merged commit b3f51be into main Feb 8, 2023
@mlp909 mlp909 deleted the feature/229-connect-unitconverter-to-frontend branch February 8, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put space between number and unit (at all places) Connect unitConverter to Frontend
3 participants