-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/229 connect unitconverter to frontend #302
Conversation
Codecov ReportBase: 90.27% // Head: 87.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 90.27% 87.64% -2.64%
==========================================
Files 52 25 -27
Lines 658 356 -302
Branches 44 28 -16
==========================================
- Hits 594 312 -282
+ Misses 64 44 -20
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Alle Gewichte sind mit der unitconverter Funktion verbunden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sieht gut aus. Zwei Sachen
- Ein Test für round numbers
Glaube da müsste ein komma stehen. Siehe: https://www.usf.edu/intousf/documents/decimal_notation_how_to_say_math_and_units_of_measurement_in_the_us.pdf
Du wolltest doch, dass das ein Punkt ist, davor war es ein Komma. :D |
Ja ist richtig so hab vercheckt das das kg sind dachte irgendwie das sind g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Close #251
Close #229