Add spell masks

wowsims · Jan 30, 2025 · 0149db5 · 0149db5
1 parent d12b875
commit 0149db5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/sim/mage/combustion.go b/sim/mage/combustion.go
@@ -152,9 +152,9 @@ func (mage *Mage) registerCombustionSpell() {
 	})
 
 	core.MakeProcTriggerAura(&mage.Unit, core.ProcTrigger{
-		Name:           "Combustion Ignite listener",
-		ClassSpellMask: MageSpellIgnite,
-		Callback:       core.CallbackOnPeriodicDamageDealt,
+		Name:           "Combustion Dot Calculation Listener",
+		ClassSpellMask: MageSpellIgnite | MageSpellPyroblastDot | MageSpellLivingBombDot,
+		Callback:       core.CallbackOnCastComplete | core.CallbackOnPeriodicDamageDealt,
 		Handler: func(sim *core.Simulation, spell *core.Spell, _ *core.SpellResult) {
 			updateCombustionTickDamageEstimate(sim)
 			updateCombustionTotalDamageEstimate(sim)

diff --git a/sim/mage/talents_fire.go b/sim/mage/talents_fire.go
@@ -374,6 +374,10 @@ func (mage *Mage) applyIgnite() {
 			return result.Damage * igniteDamageMultiplier * masteryMultiplier
 		},
 	})
+
+	// This is needed because we want to listen for the spell "cast" event that refreshes the Dot
+	mage.Ignite.Flags ^= core.SpellFlagNoOnCastComplete
+
 }
 
 func (mage *Mage) applyImpact() {