Merge pull request #903 from zoristaken/update-capacitor-proc-chance

update firelands capacitor proc chance
wowsims · Aug 3, 2024 · 2670f37 · 2670f37
2 parents f9d0e95 + 1b191cc
commit 2670f37
Show file tree

Hide file tree

Showing 17 changed files with 62 additions and 62 deletions.
diff --git a/sim/common/cata/damage_procs.go b/sim/common/cata/damage_procs.go
@@ -44,7 +44,7 @@ func init() {
 
 	core.NewItemEffect(68925, func(agent core.Agent) {
 		character := agent.GetCharacter()
-		procChance := 0.3 //TODO: placeholder, get real proc chance
+		procChance := 0.15 //TODO: simc proc chance, verify when available
 		dummyAura := character.GetOrRegisterAura(core.Aura{
 			Label:     "Electrical Charge",
 			ActionID:  core.ActionID{SpellID: 96890},
@@ -89,7 +89,7 @@ func init() {
 
 	core.NewItemEffect(69110, func(agent core.Agent) {
 		character := agent.GetCharacter()
-		procChance := 0.3 //TODO: placeholder, get real proc chance
+		procChance := 0.15 //TODO: simc proc chance, verify when available
 		dummyAura := character.GetOrRegisterAura(core.Aura{
 			Label:     "Electrical Charge",
 			ActionID:  core.ActionID{SpellID: 96890},

diff --git a/sim/death_knight/blood/TestBlood.results b/sim/death_knight/blood/TestBlood.results
@@ -1453,16 +1453,16 @@ dps_results: {
 dps_results: {
  key: "TestBlood-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 13808.52495
-  tps: 67014.70121
+  dps: 13806.49665
+  tps: 67001.4247
   hps: 3597.80333
  }
 }
 dps_results: {
  key: "TestBlood-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 13814.20081
-  tps: 67045.83309
+  dps: 13812.19782
+  tps: 67038.77942
   hps: 3597.80333
  }
 }

diff --git a/sim/death_knight/frost/TestFrost.results b/sim/death_knight/frost/TestFrost.results
@@ -1453,16 +1453,16 @@ dps_results: {
 dps_results: {
  key: "TestFrost-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 20778.22388
-  tps: 18939.79361
+  dps: 20759.51981
+  tps: 18919.10027
   hps: 215.12703
  }
 }
 dps_results: {
  key: "TestFrost-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 20834.97419
-  tps: 19000.58033
+  dps: 20796.72379
+  tps: 18961.11985
   hps: 215.82777
  }
 }

diff --git a/sim/death_knight/unholy/TestUnholy.results b/sim/death_knight/unholy/TestUnholy.results
@@ -1452,16 +1452,16 @@ dps_results: {
 dps_results: {
  key: "TestUnholy-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 29757.62305
-  tps: 22139.36776
+  dps: 29777.19971
+  tps: 22143.47508
   hps: 473.88367
  }
 }
 dps_results: {
  key: "TestUnholy-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 29871.3464
-  tps: 22243.66805
+  dps: 29837.94088
+  tps: 22233.86006
   hps: 473.88367
  }
 }

diff --git a/sim/druid/feral/TestFeral.results b/sim/druid/feral/TestFeral.results
@@ -1277,8 +1277,8 @@ dps_results: {
 dps_results: {
  key: "TestFeral-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 24979.6601
-  tps: 35223.86618
+  dps: 24977.54104
+  tps: 35213.26669
  }
 }
 dps_results: {

diff --git a/sim/druid/guardian/TestGuardian.results b/sim/druid/guardian/TestGuardian.results
@@ -1277,15 +1277,15 @@ dps_results: {
 dps_results: {
  key: "TestGuardian-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 7515.9011
-  tps: 37644.53197
+  dps: 7502.22428
+  tps: 37576.49851
  }
 }
 dps_results: {
  key: "TestGuardian-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 7583.93862
-  tps: 37984.95102
+  dps: 7606.1776
+  tps: 38096.12593
  }
 }
 dps_results: {

diff --git a/sim/hunter/survival/TestSV.results b/sim/hunter/survival/TestSV.results
@@ -1312,8 +1312,8 @@ dps_results: {
 dps_results: {
  key: "TestSV-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 24463.25663
-  tps: 22099.7578
+  dps: 24462.37733
+  tps: 22098.81331
  }
 }
 dps_results: {

diff --git a/sim/mage/arcane/TestArcane.results b/sim/mage/arcane/TestArcane.results
@@ -1249,15 +1249,15 @@ dps_results: {
 dps_results: {
  key: "TestArcane-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 29612.25417
-  tps: 29791.85972
+  dps: 29503.45156
+  tps: 29675.20557
  }
 }
 dps_results: {
  key: "TestArcane-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 30304.71084
-  tps: 30485.00192
+  dps: 30143.24127
+  tps: 30315.90674
  }
 }
 dps_results: {

diff --git a/sim/mage/fire/TestFire.results b/sim/mage/fire/TestFire.results
@@ -1249,15 +1249,15 @@ dps_results: {
 dps_results: {
  key: "TestFire-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 30641.82718
-  tps: 30017.96402
+  dps: 30289.47261
+  tps: 29662.71572
  }
 }
 dps_results: {
  key: "TestFire-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 31095.70522
-  tps: 30448.5247
+  dps: 31122.71035
+  tps: 30467.58986
  }
 }
 dps_results: {

diff --git a/sim/paladin/retribution/TestRetribution.results b/sim/paladin/retribution/TestRetribution.results
@@ -1298,15 +1298,15 @@ dps_results: {
 dps_results: {
  key: "TestRetribution-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 30223.94111
-  tps: 30235.04992
+  dps: 30222.0388
+  tps: 30233.1476
  }
 }
 dps_results: {
  key: "TestRetribution-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 30448.24528
-  tps: 30458.90702
+  dps: 30410.76328
+  tps: 30421.42502
  }
 }
 dps_results: {

diff --git a/sim/priest/shadow/TestShadow.results b/sim/priest/shadow/TestShadow.results
@@ -1291,15 +1291,15 @@ dps_results: {
 dps_results: {
  key: "TestShadow-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 28441.79764
-  tps: 26839.47652
+  dps: 28468.58197
+  tps: 26848.62777
  }
 }
 dps_results: {
  key: "TestShadow-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 28862.30722
-  tps: 27231.26969
+  dps: 28755.20278
+  tps: 27126.77264
  }
 }
 dps_results: {

diff --git a/sim/rogue/assassination/TestAssassination.results b/sim/rogue/assassination/TestAssassination.results
@@ -1249,15 +1249,15 @@ dps_results: {
 dps_results: {
  key: "TestAssassination-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 27950.1948
-  tps: 19844.63831
+  dps: 27925.65691
+  tps: 19827.21641
  }
 }
 dps_results: {
  key: "TestAssassination-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 28032.00416
-  tps: 19902.72296
+  dps: 28047.28602
+  tps: 19913.57308
  }
 }
 dps_results: {

diff --git a/sim/shaman/elemental/TestElemental.results b/sim/shaman/elemental/TestElemental.results
@@ -1312,15 +1312,15 @@ dps_results: {
 dps_results: {
  key: "TestElemental-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 31638.95388
-  tps: 928.78658
+  dps: 31689.44963
+  tps: 872.56263
  }
 }
 dps_results: {
  key: "TestElemental-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 32700.28735
-  tps: 1586.79755
+  dps: 32474.30945
+  tps: 1443.38277
  }
 }
 dps_results: {

diff --git a/sim/shaman/enhancement/TestEnhancement.results b/sim/shaman/enhancement/TestEnhancement.results
@@ -1312,15 +1312,15 @@ dps_results: {
 dps_results: {
  key: "TestEnhancement-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 28033.37912
-  tps: 18770.19817
+  dps: 27991.98336
+  tps: 18735.88667
  }
 }
 dps_results: {
  key: "TestEnhancement-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 28532.12045
-  tps: 19286.92353
+  dps: 28425.04938
+  tps: 19127.36609
  }
 }
 dps_results: {

diff --git a/sim/warlock/affliction/TestAffliction.results b/sim/warlock/affliction/TestAffliction.results
@@ -1249,15 +1249,15 @@ dps_results: {
 dps_results: {
  key: "TestAffliction-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 27501.28156
-  tps: 20533.65947
+  dps: 27347.94689
+  tps: 20471.25429
  }
 }
 dps_results: {
  key: "TestAffliction-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 27787.83005
-  tps: 20896.43197
+  dps: 27738.77776
+  tps: 20841.4632
  }
 }
 dps_results: {

diff --git a/sim/warlock/demonology/TestDemonology.results b/sim/warlock/demonology/TestDemonology.results
@@ -1249,15 +1249,15 @@ dps_results: {
 dps_results: {
  key: "TestDemonology-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 28260.23692
-  tps: 15022.11802
+  dps: 28162.41882
+  tps: 14950.60008
  }
 }
 dps_results: {
  key: "TestDemonology-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 28741.87183
-  tps: 15407.13312
+  dps: 28562.14957
+  tps: 15344.51596
  }
 }
 dps_results: {

diff --git a/sim/warlock/destruction/TestDestruction.results b/sim/warlock/destruction/TestDestruction.results
@@ -1249,15 +1249,15 @@ dps_results: {
 dps_results: {
  key: "TestDestruction-AllItems-VariablePulseLightningCapacitor-68925"
  value: {
-  dps: 27718.60657
-  tps: 18468.59303
+  dps: 27772.75073
+  tps: 18530.10995
  }
 }
 dps_results: {
  key: "TestDestruction-AllItems-VariablePulseLightningCapacitor-69110"
  value: {
-  dps: 28277.88459
-  tps: 18951.43424
+  dps: 28293.20167
+  tps: 19018.9195
  }
 }
 dps_results: {