Skip to content

Commit

Permalink
Merge pull request #1184 from hillerstorm/blood_strike
Browse files Browse the repository at this point in the history
[Blood] Add Blood Strike to DRW copy just because we can
  • Loading branch information
hillerstorm authored Nov 7, 2024
2 parents 246ed3f + ffdd1ee commit 3c4b851
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
22 changes: 19 additions & 3 deletions sim/death_knight/blood_strike.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import (
"github.com/wowsims/cata/sim/core/proto"
)

var bloodStrikeActionID = core.ActionID{SpellID: 45902}
var BloodStrikeActionID = core.ActionID{SpellID: 45902}

func (dk *DeathKnight) registerBloodStrikeSpell() {
ohSpell := dk.GetOrRegisterSpell(core.SpellConfig{
ActionID: bloodStrikeActionID.WithTag(2),
ActionID: BloodStrikeActionID.WithTag(2),
SpellSchool: core.SpellSchoolPhysical,
ProcMask: core.ProcMaskMeleeOHSpecial,
Flags: core.SpellFlagMeleeMetrics,
Expand All @@ -33,7 +33,7 @@ func (dk *DeathKnight) registerBloodStrikeSpell() {
hasReaping := dk.Inputs.Spec == proto.Spec_SpecUnholyDeathKnight

dk.GetOrRegisterSpell(core.SpellConfig{
ActionID: bloodStrikeActionID.WithTag(1),
ActionID: BloodStrikeActionID.WithTag(1),
SpellSchool: core.SpellSchoolPhysical,
ProcMask: core.ProcMaskMeleeMHSpecial,
Flags: core.SpellFlagMeleeMetrics | core.SpellFlagAPL,
Expand Down Expand Up @@ -74,3 +74,19 @@ func (dk *DeathKnight) registerBloodStrikeSpell() {
},
})
}

func (dk *DeathKnight) registerDrwBloodStrikeSpell() *core.Spell {
return dk.RuneWeapon.RegisterSpell(core.SpellConfig{
ActionID: BloodStrikeActionID.WithTag(1),
SpellSchool: core.SpellSchoolPhysical,
ProcMask: core.ProcMaskMeleeMHSpecial,
Flags: core.SpellFlagMeleeMetrics,

ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
baseDamage := dk.ClassSpellScaling*0.75599998236 +
spell.Unit.MHNormalizedWeaponDamage(sim, spell.MeleeAttackPower())

spell.CalcAndDealDamage(sim, target, baseDamage, spell.OutcomeMeleeWeaponSpecialHitAndCrit)
},
})
}
1 change: 1 addition & 0 deletions sim/death_knight/dancing_rune_weapon.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ func (runeWeapon *RuneWeaponPet) Initialize() {
runeWeapon.AddCopySpell(DeathStrikeActionID.WithTag(1), runeWeapon.dkOwner.registerDrwDeathStrikeSpell())
runeWeapon.AddCopySpell(RuneStrikeActionID.WithTag(1), runeWeapon.dkOwner.registerDrwRuneStrikeSpell())
runeWeapon.AddCopySpell(FesteringStrikeActionID.WithTag(1), runeWeapon.dkOwner.registerDrwFesteringStrikeSpell())
runeWeapon.AddCopySpell(BloodStrikeActionID.WithTag(1), runeWeapon.dkOwner.registerDrwBloodStrikeSpell())
}

func (runeWeapon *RuneWeaponPet) AddCopySpell(actionId core.ActionID, spell *core.Spell) {
Expand Down

0 comments on commit 3c4b851

Please sign in to comment.