Merge pull request #1088 from wowsims/bugfix/damage-taken-percent

Add DTPS Percent metric
wowsims · Oct 8, 2024 · 565cafa · 565cafa
2 parents 1547d76 + 3614633
commit 565cafa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/ui/core/components/detailed_results/dtps_metrics.tsx b/ui/core/components/detailed_results/dtps_metrics.tsx
@@ -35,7 +35,7 @@ export class DtpsMetricsTable extends MetricsTable<ActionMetrics> {
 					cellElem.appendChild(
 						<MetricsTotalBar
 							spellSchool={metric.spellSchool}
-							percentage={metric.totalDamagePercent}
+							percentage={metric.totalDamageTakenPercent}
 							max={this.maxDtpsAmount}
 							total={metric.avgDamage}
 							value={metric.damage}

diff --git a/ui/core/proto_utils/sim_result.ts b/ui/core/proto_utils/sim_result.ts
@@ -794,6 +794,13 @@ export class ActionMetrics {
 		return this.data.isPassive;
 	}
 
+	get totalDamageTakenPercent() {
+		const totalAvgDtps = this.resultData.result.encounterMetrics?.targets?.[this.unit?.unitIndex || 0].dps?.avg;
+		if (!totalAvgDtps) return undefined;
+
+		return (this.avgDamage / (totalAvgDtps * this.duration)) * 100;
+	}
+
 	get totalDamagePercent() {
 		const totalAvgDps = this.resultData.result.raidMetrics?.dps?.avg;
 		if (!totalAvgDps) return undefined;