Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
warlock: fix mastery coef for affli 1.63 -> 1.625
Browse files Browse the repository at this point in the history
The tooltip incorrectly states that a point of mastery gives 1.63%
increased periodic shadow damage, but both dbc values and ingame tests
show that value to be 1.625 instead.

Tests illustrating the differences ingame:

990 mastery: https://classic.warcraftlogs.com/reports/dMA2t6wLjD7TcCpN#fight=4&type=damage-done&view=events&ability=-172
1000 mastery: https://classic.warcraftlogs.com/reports/dMA2t6wLjD7TcCpN#fight=5&type=damage-done&view=events&ability=-172
Tharre committed Jul 24, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent cce2f14 commit 894f4d5
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sim/warlock/affliction/affliction.go
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ type AfflictionWarlock struct {
}

func (affliction AfflictionWarlock) getMasteryBonus() float64 {
return math.Floor(13.04+1.63*affliction.GetMasteryPoints()) / 100.0
return math.Floor(13.04+1.625*affliction.GetMasteryPoints()) / 100.0
}

func (affliction *AfflictionWarlock) GetWarlock() *warlock.Warlock {
2 changes: 1 addition & 1 deletion ui/core/constants/mechanics.ts
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ export const masteryPercentPerPoint: Map<Spec, number> = new Map([
[Spec.SpecDisciplinePriest, 2.5],
[Spec.SpecHolyPriest, 1.25],
[Spec.SpecShadowPriest, 1.45],
[Spec.SpecAfflictionWarlock, 1.63],
[Spec.SpecAfflictionWarlock, 1.625],
[Spec.SpecDemonologyWarlock, 2.3],
[Spec.SpecDestructionWarlock, 1.35],
]);

0 comments on commit 894f4d5

Please sign in to comment.