Skip to content

Commit

Permalink
[Ret] Fix prepull guardian hit for Draenei
Browse files Browse the repository at this point in the history
  • Loading branch information
hillerstorm committed Dec 12, 2024
1 parent 6ec51b3 commit 9eb3e44
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions sim/paladin/ancient_guardian_pet.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,28 @@ func (ancientGuardian *AncientGuardianPet) registerRetributionVariant() {
AutoSwingMelee: true,
})

percentHitToExpertiseRating := 1 * core.PhysicalHitRatingPerHitPercent * PetExpertiseScale
draeneiPrepull := false
ancientGuardian.OnPetEnable = func(sim *core.Simulation) {
// Since Draenei racial doesn't apply to guardian, any Draenei who uses the T11 prot prepull set
// should make sure it's reforged/enchanted to 9% hit to avoid misses and dodges.
// Having a separate input for prepull set hit rating is too much of a hassle, so we just assume it's always 9%.
if sim.CurrentTime < 0 && ancientGuardian.paladinOwner.Race == proto.Race_RaceDraenei && ancientGuardian.paladinOwner.SnapshotGuardian {
ancientGuardian.AddStatDynamic(sim, stats.PhysicalHitPercent, 1.0)
ancientGuardian.AddStatDynamic(sim, stats.ExpertiseRating, percentHitToExpertiseRating)
draeneiPrepull = true
} else {
draeneiPrepull = false
}

ancientPowerAura.Activate(sim)
}
ancientGuardian.OnPetDisable = func(sim *core.Simulation) {
if draeneiPrepull {
ancientGuardian.AddStatDynamic(sim, stats.PhysicalHitPercent, -1.0)
ancientGuardian.AddStatDynamic(sim, stats.ExpertiseRating, -percentHitToExpertiseRating)
}

ancientPowerAura.Deactivate(sim)
}
}
Expand Down

0 comments on commit 9eb3e44

Please sign in to comment.