Skip to content

Commit

Permalink
Merge pull request #1314 from hillerstorm/enable_item_swap_slots
Browse files Browse the repository at this point in the history
[DK] Enable all item swap slots for FDK and UDK
  • Loading branch information
hillerstorm authored Jan 19, 2025
2 parents 18fd26f + 872d741 commit a2c2768
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 2 deletions.
20 changes: 19 additions & 1 deletion ui/death_knight/frost/sim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,25 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecFrostDeathKnight, {
OtherInputs.DarkIntentUptime,
],
},
itemSwapSlots: [ItemSlot.ItemSlotMainHand, ItemSlot.ItemSlotOffHand, ItemSlot.ItemSlotTrinket1, ItemSlot.ItemSlotTrinket2],
itemSwapSlots: [
ItemSlot.ItemSlotHead,
ItemSlot.ItemSlotNeck,
ItemSlot.ItemSlotShoulder,
ItemSlot.ItemSlotBack,
ItemSlot.ItemSlotChest,
ItemSlot.ItemSlotWrist,
ItemSlot.ItemSlotHands,
ItemSlot.ItemSlotWaist,
ItemSlot.ItemSlotLegs,
ItemSlot.ItemSlotFeet,
ItemSlot.ItemSlotFinger1,
ItemSlot.ItemSlotFinger2,
ItemSlot.ItemSlotTrinket1,
ItemSlot.ItemSlotTrinket2,
ItemSlot.ItemSlotMainHand,
ItemSlot.ItemSlotOffHand,
ItemSlot.ItemSlotRanged,
],
encounterPicker: {
showExecuteProportion: false,
},
Expand Down
20 changes: 19 additions & 1 deletion ui/death_knight/unholy/sim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,25 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecUnholyDeathKnight, {
OtherInputs.DarkIntentUptime,
],
},
itemSwapSlots: [ItemSlot.ItemSlotMainHand, ItemSlot.ItemSlotOffHand, ItemSlot.ItemSlotTrinket1, ItemSlot.ItemSlotTrinket2],
itemSwapSlots: [
ItemSlot.ItemSlotHead,
ItemSlot.ItemSlotNeck,
ItemSlot.ItemSlotShoulder,
ItemSlot.ItemSlotBack,
ItemSlot.ItemSlotChest,
ItemSlot.ItemSlotWrist,
ItemSlot.ItemSlotHands,
ItemSlot.ItemSlotWaist,
ItemSlot.ItemSlotLegs,
ItemSlot.ItemSlotFeet,
ItemSlot.ItemSlotFinger1,
ItemSlot.ItemSlotFinger2,
ItemSlot.ItemSlotTrinket1,
ItemSlot.ItemSlotTrinket2,
ItemSlot.ItemSlotMainHand,
ItemSlot.ItemSlotOffHand,
ItemSlot.ItemSlotRanged,
],
encounterPicker: {
// Whether to include 'Execute Duration (%)' in the 'Encounter' section of the settings tab.
showExecuteProportion: false,
Expand Down

0 comments on commit a2c2768

Please sign in to comment.