Merge pull request #1247 from wowsims/fix/warlock-felguard-spell-haste

[WARLOCK] DS:FG Change CastTime mod to CastSpeed
wowsims · Dec 4, 2024 · f52408b · f52408b
2 parents c504b44 + 9588ae7
commit f52408b
Show file tree

Hide file tree

Showing 2 changed files with 750 additions and 755 deletions.
diff --git a/sim/warlock/demon_soul.go b/sim/warlock/demon_soul.go
@@ -45,12 +45,7 @@ func (warlock *Warlock) registerDemonSoul() {
 		},
 	})
 
-	felguardHasteMod := warlock.AddDynamicMod(core.SpellModConfig{
-		Kind:       core.SpellMod_CastTime_Pct,
-		ClassMask:  WarlockFireDamage | WarlockShadowDamage,
-		FloatValue: -0.15,
-	})
-
+	felguardHasteMulti := 1.15
 	felguardDamageMod := warlock.AddDynamicMod(core.SpellModConfig{
 		Kind:       core.SpellMod_DamageDone_Pct,
 		School:     core.SpellSchoolShadow | core.SpellSchoolFire,
@@ -62,11 +57,11 @@ func (warlock *Warlock) registerDemonSoul() {
 		ActionID: core.ActionID{SpellID: 79462},
 		Duration: 20 * time.Second,
 		OnGain: func(aura *core.Aura, sim *core.Simulation) {
-			felguardHasteMod.Activate()
+			warlock.MultiplyCastSpeed(felguardHasteMulti)
 			felguardDamageMod.Activate()
 		},
 		OnExpire: func(aura *core.Aura, sim *core.Simulation) {
-			felguardHasteMod.Deactivate()
+			warlock.MultiplyCastSpeed(1 / felguardHasteMulti)
 			felguardDamageMod.Deactivate()
 		},
 	})