Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklist proc trinkets with extra proc conditions from APL aura sets #1166

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Blacklist proc trinkets with extra proc conditions from APL aura sets #1166

merged 2 commits into from
Nov 4, 2024

Conversation

NerdEgghead
Copy link
Contributor

Currently only affects the Sorrowsong trinket.

@NerdEgghead
Blacklist proc trinkets with extra proc conditions from APL aura sets
b8ba62f 
 On branch feature/apl-aura-sets
 Changes to be committed:
	modified:   sim/common/shared/shared_utils.go
	modified:   sim/shaman/elemental/TestElemental.results
@github-actions github-actions bot added the Shaman label Nov 4, 2024
@NerdEgghead NerdEgghead requested a review from Polynomix November 4, 2024 19:33
@Polynomix
Copy link
Contributor

This will blacklist entirely sorrowsong. It can still proc under 35% hp and should be included in the tests then. If not, it doesn't solve the problem that the apl will include specific handling for sorrowsong. There is also 2 other tank trinkets that uses custom conditions, I'm not a tank expert but they might encounter the same issue if someone decides to equip one.
What do you think of testing if the extra condition is satisfied here ?

@NerdEgghead
Refactored StatBuffAura and NewProcStatBonusEffect code so that any
0c5b237 
custom proc conditions can be checked during calls to
AllTrinketStatProcsActive().

 On branch feature/apl-aura-sets
 Changes to be committed:
	modified:   sim/common/cata/stat_bonus_procs.go
	modified:   sim/common/shared/shared_utils.go
	modified:   sim/core/apl_values_aura_sets.go
	modified:   sim/core/aura_helpers.go
	modified:   sim/shaman/elemental/TestElemental.results
	modified:   sim/warlock/demonology/TestDemonology.results
@NerdEgghead
Copy link
Contributor Author

This will blacklist entirely sorrowsong. It can still proc under 35% hp and should be included in the tests then. If not, it doesn't solve the problem that the apl will include specific handling for sorrowsong. There is also 2 other tank trinkets that uses custom conditions, I'm not a tank expert but they might encounter the same issue if someone decides to equip one.
What do you think of testing if the extra condition is satisfied here ?

Took some refactoring, but I think it should be behaving the way you want now.

@NerdEgghead NerdEgghead merged commit d0e986d into master Nov 4, 2024
2 checks passed
@NerdEgghead NerdEgghead deleted the feature/apl-aura-sets branch November 4, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polynomix Polynomix Polynomix approved these changes

Assignees
No one assigned
Labels
Shaman Warlock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NerdEgghead @Polynomix