-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shaman] Some tweaks and a couple fixes #121
Conversation
fixes for unleash elements fix elemental oath earthquake bug fix lavalash cd fix searing totem tick time and enable searing and magma totem to get totemic focus bonuses remove some todo comments
merge from master
…wsims-cata into more-shaman-fixes
update gear sets, apl, talent presets, and defaults for ele and enhance
@@ -178,7 +180,9 @@ func (shaman *Shaman) applyElementalFocus() { | |||
shaman.PseudoStats.SchoolDamageDealtMultiplier[stats.SchoolIndexNature] /= oathBonus | |||
shaman.PseudoStats.SchoolDamageDealtMultiplier[stats.SchoolIndexFire] /= oathBonus | |||
shaman.PseudoStats.SchoolDamageDealtMultiplier[stats.SchoolIndexFrost] /= oathBonus | |||
shaman.Earthquake.DamageMultiplierAdditive -= 0.05 | |||
if shaman.Earthquake != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you fix open Issues I'd advise to add the note in the PR or respective commit.
Fixes: #ticketNumber
Github will automaticaly link commit and issue so they're visible and close the ticket on merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍 I agree with the comments otherwise it'll be ready to go after
fix flame shock so the dot can crit apply glyphs and armor spec in the talents like the dk implementation add the fire, nature, frost spell masks and use these for the elemental fury mod instead of school damage update tests
Thanks guys. This should be ready to go with the latest commit fixing a few other things as well. |
fixes for unleash elements
fix elemental oath earthquake bug Fixes: #117 Fixes: #118
fix lavalash cd
fix searing totem tick time and enable searing and magma totem to get totemic focus bonuses
remove some todo comments
fix elemental fury crit
add shaman tests
update gear sets, apl, talent presets, and defaults for ele and enhance
fix fire nova
fix flame shock dot so it can crit
fix the spell masks on elemental fury crit