Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shaman] Some tweaks and a couple fixes #121

Merged
merged 11 commits into from
Apr 21, 2024

Conversation

ghronkrepps
Copy link
Contributor

@ghronkrepps ghronkrepps commented Apr 19, 2024

fixes for unleash elements
fix elemental oath earthquake bug Fixes: #117 Fixes: #118
fix lavalash cd
fix searing totem tick time and enable searing and magma totem to get totemic focus bonuses
remove some todo comments
fix elemental fury crit
add shaman tests
update gear sets, apl, talent presets, and defaults for ele and enhance
fix fire nova
fix flame shock dot so it can crit
fix the spell masks on elemental fury crit

fixes for unleash elements
fix elemental oath earthquake bug
fix lavalash cd
fix searing totem tick time and enable searing and magma totem to get totemic focus bonuses
remove some todo comments
merge from master
@@ -178,7 +180,9 @@ func (shaman *Shaman) applyElementalFocus() {
shaman.PseudoStats.SchoolDamageDealtMultiplier[stats.SchoolIndexNature] /= oathBonus
shaman.PseudoStats.SchoolDamageDealtMultiplier[stats.SchoolIndexFire] /= oathBonus
shaman.PseudoStats.SchoolDamageDealtMultiplier[stats.SchoolIndexFrost] /= oathBonus
shaman.Earthquake.DamageMultiplierAdditive -= 0.05
if shaman.Earthquake != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you fix open Issues I'd advise to add the note in the PR or respective commit.
Fixes: #ticketNumber Github will automaticaly link commit and issue so they're visible and close the ticket on merge.

Copy link
Contributor

@kayla-glick kayla-glick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 I agree with the comments otherwise it'll be ready to go after

fix flame shock so the dot can crit
apply glyphs and armor spec in the talents like the dk implementation
add the fire, nature, frost spell masks and use these for the elemental fury mod instead of school damage
update tests
@ghronkrepps
Copy link
Contributor Author

Thanks guys. This should be ready to go with the latest commit fixing a few other things as well.

@InDebt InDebt merged commit 89c9409 into wowsims:master Apr 21, 2024
1 check passed
@ghronkrepps ghronkrepps deleted the more-shaman-fixes branch April 22, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash Report 590903085 Crash Report 1529238438
3 participants