Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Feature/improve detailed results performance #1241

Merged
merged 3 commits into from
Jan 4, 2025
Merged

[UI] Feature/improve detailed results performance #1241

merged 3 commits into from
Jan 4, 2025

Conversation

1337LutZ
Copy link
Contributor

@1337LutZ 1337LutZ commented Dec 2, 2024 •
edited
Loading

  • Added the request ID to the raid sim request to have a unique value to build cache keys with
  • Added a generic CacheHandler to allow for caching of elements that do not change and can be reused.
  • Added caching to diverse "enriched" HTML Nodes that are dependent on async calls like wowhead datasets
  • Added caching (max 2 entries) to SimResults to make toggling between 2 (reference) datasets much quicker
  • Added caching to the Timeline content
  • Fixed DPS graph Timeline tooltips

After & Before
~ 3x performance increase when swapping/toggling between 2 results
Overall GC improvement
image

@hillerstorm
Copy link
Contributor

This should be mergeable right @1337LutZ ?

@1337LutZ
Copy link
Contributor Author

This should be mergeable right @1337LutZ ?

Yes! If others tested it and found now issues 👌

@1337LutZ 1337LutZ merged commit 64ca4bc into master Jan 4, 2025
2 checks passed
@1337LutZ 1337LutZ deleted the feature/improve-detailed-results-performance branch January 4, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToxicKevinFerm ToxicKevinFerm ToxicKevinFerm approved these changes

@hillerstorm hillerstorm hillerstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1337LutZ @hillerstorm @ToxicKevinFerm