[Warrior] Fix Rend damage formula #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The damage formula for Rend was a bit off, it was copied from the tooltip which has a 6x multiplier in it that shouldn't be there. In this case, that
*6in the tooltip should in fact be a 5 since it's the tick count (tooltip does show total damage over 15sec).Sim also used the rounded, final value from the tooltip instead of using the class scaling coefficient and spell effect avg.
Compared from a guildies log and his exact gear imported to the sim with the same buffs and found a place where no extra AP modifiers or other stuff was active.
Sorry for nerfing but all is as it should be 😆