Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Improve drag-and-drop support in APL editor #1273

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

hillerstorm
Copy link
Contributor

Doing a ton of APL editing highlighted a few missing features that would really speed things up, so I added them!

  • Drag and drop APL values inside an Any of / All of
    • Not restricted to the same list, can be moved in/out any number of levels and even between different APL actions
  • Being able to copy an APL value inside an Any of / All of
  • Clearer indication of what block will be deleted inside nested Any of / All of
  • Having the whole block show up as the drag-placeholder instead of just the move-button

Any feedback is appreciated!

drag_n_drop.mp4

@@ -277,16 +281,18 @@ export class ListPicker<ModObject, ItemType> extends Input<ModObject, Array<Item
},
{ signal: this.signal },
);

const invalidDropTarget = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what I meant :D

Copy link
Contributor

@1337LutZ 1337LutZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the feature myself, but code wise it looks cleaner :D thanks for making some of the small util fns

@hillerstorm hillerstorm merged commit 4bdf5b0 into wowsims:master Dec 22, 2024
2 checks passed
@hillerstorm hillerstorm deleted the drag-n-drop-experiment branch December 22, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants