Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Always show spell tooltip instead of glyph item tooltip #1278

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

hillerstorm
Copy link
Contributor

Had a special case fix for Glyph of Fireball before since the item tooltip says 5% damage but the spell shows the correct 5% crit. This PR just does this for all glyphs across the board, to never show "empty" tooltips.

Old:
image

New:
image

@hillerstorm hillerstorm merged commit 8e9998c into wowsims:master Dec 31, 2024
3 checks passed
@hillerstorm hillerstorm deleted the glyph_fixes branch December 31, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant