Keep Energy and Focus tick randomized during reset actions. #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch feature/add-trinket-swapping Changes to be committed: modified: sim/core/energy.go modified: sim/core/focus.go modified: sim/death_knight/unholy/TestUnholy.results modified: sim/hunter/beast_mastery/TestBM.results modified: sim/rogue/combat/TestCombat.results modified: sim/rogue/subtlety/TestSubtlety.results
|
While fixing a concurrency failure for Rogue + Hunter in the massive item swapping PR #1253 , I realized that the intended randomization of the Energy and Focus tick timers is often "un-done" during the reset process between iterations, because any Haste buffs that activate in between the Energy/Focus bar's reset action and the start of the pull end up re-syncing the timer to 0. This PR aims to fix that: @TheBackstabi @ToxicKevinFerm can you guys do a quick sanity check that the sims behave fine with this change in place given that there are test results changes? |
ToxicKevinFerm
approved these changes
Jan 7, 2025
|
Also seems fine on my end. The final differences aren't large enough to be concerning and not seeing any failures. |
TheBackstabi
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On branch feature/add-trinket-swapping
Changes to be committed:
modified: sim/core/energy.go
modified: sim/core/focus.go
modified: sim/death_knight/unholy/TestUnholy.results
modified: sim/hunter/beast_mastery/TestBM.results
modified: sim/rogue/combat/TestCombat.results
modified: sim/rogue/subtlety/TestSubtlety.results