Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Seal of the Seven Signs #1295

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Implement Seal of the Seven Signs #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sim/common/cata/stat_bonus_procs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,18 @@ func init() {
ICD: time.Second * 115,
})

shared.NewProcStatBonusEffect(shared.ProcStatBonusEffect{
Name: "Seal of the Seven Signs" + labelSuffix,
ID: []int32{77969, 77204, 77989}[version],
AuraID: []int32{109803, 107984, 109805}[version],
Bonus: stats.Stats{stats.HasteRating: []float64{2573, 2904, 3278}[version]},
Duration: time.Second * 20,
Callback: core.CallbackOnHealDealt | core.CallbackOnPeriodicHealDealt,
ProcMask: core.ProcMaskSpellHealing,
ProcChance: 0.15,
ICD: time.Second * 115,
})

shared.NewProcStatBonusEffect(shared.ProcStatBonusEffect{
Name: "Soulshifter Vortex" + labelSuffix,
ID: []int32{77970, 77206, 77990}[version],
Expand Down
24 changes: 24 additions & 0 deletions sim/death_knight/blood/TestBlood.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1603,6 +1603,30 @@ dps_results: {
hps: 5300.29889
}
}
dps_results: {
key: "TestBlood-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 22115.12597
tps: 111531.13752
hps: 5457.04271
}
}
dps_results: {
key: "TestBlood-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 22009.66333
tps: 110377.7788
hps: 5456.37743
}
}
dps_results: {
key: "TestBlood-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 22378.91459
tps: 112308.53866
hps: 5467.11498
}
}
dps_results: {
key: "TestBlood-AllItems-Shadowmourne-49623"
value: {
Expand Down
24 changes: 24 additions & 0 deletions sim/death_knight/frost/TestFrost.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,6 +1635,30 @@ dps_results: {
hps: 521.88199
}
}
dps_results: {
key: "TestFrost-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 38688.87584
tps: 36488.59781
hps: 539.77064
}
}
dps_results: {
key: "TestFrost-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 38762.29847
tps: 36523.18172
hps: 535.10404
}
}
dps_results: {
key: "TestFrost-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 38942.55976
tps: 36736.21674
hps: 531.99297
}
}
dps_results: {
key: "TestFrost-AllItems-Shadowmourne-49623"
value: {
Expand Down
24 changes: 24 additions & 0 deletions sim/death_knight/unholy/TestUnholy.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,6 +1611,30 @@ dps_results: {
hps: 646.50919
}
}
dps_results: {
key: "TestUnholy-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 39915.83599
tps: 29462.91364
hps: 659.8312
}
}
dps_results: {
key: "TestUnholy-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 39920.37289
tps: 29491.48114
hps: 653.56202
}
}
dps_results: {
key: "TestUnholy-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 40160.97481
tps: 29701.00924
hps: 662.96579
}
}
dps_results: {
key: "TestUnholy-AllItems-Shadowmourne-49623"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/druid/balance/TestBalance.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,6 +1445,27 @@ dps_results: {
tps: 27667.93127
}
}
dps_results: {
key: "TestBalance-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 28379.82347
tps: 28395.90986
}
}
dps_results: {
key: "TestBalance-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 28194.09114
tps: 28211.00984
}
}
dps_results: {
key: "TestBalance-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 28588.22921
tps: 28603.33637
}
}
dps_results: {
key: "TestBalance-AllItems-ShardofWoe-60233"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/druid/feral/TestFeral.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,6 +1438,27 @@ dps_results: {
tps: 46454.53299
}
}
dps_results: {
key: "TestFeral-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 30947.06126
tps: 46123.89422
}
}
dps_results: {
key: "TestFeral-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 30947.06126
tps: 46123.93807
}
}
dps_results: {
key: "TestFeral-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 30947.06126
tps: 46123.84446
}
}
dps_results: {
key: "TestFeral-AllItems-ShardofWoe-60233"
value: {
Expand Down
24 changes: 24 additions & 0 deletions sim/druid/guardian/TestGuardian.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,6 +1643,30 @@ dps_results: {
hps: 314.83292
}
}
dps_results: {
key: "TestGuardian-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 9705.01597
tps: 48591.91358
hps: 316.2575
}
}
dps_results: {
key: "TestGuardian-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 9645.52154
tps: 48295.05416
hps: 316.2575
}
}
dps_results: {
key: "TestGuardian-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 9675.68712
tps: 48446.00079
hps: 319.10667
}
}
dps_results: {
key: "TestGuardian-AllItems-ShardofWoe-60233"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/hunter/beast_mastery/TestBM.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,6 +1508,27 @@ dps_results: {
tps: 15118.55967
}
}
dps_results: {
key: "TestBM-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 23897.65495
tps: 15118.55967
}
}
dps_results: {
key: "TestBM-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 23897.65495
tps: 15118.55967
}
}
dps_results: {
key: "TestBM-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 23897.65495
tps: 15118.55967
}
}
dps_results: {
key: "TestBM-AllItems-Shadowmourne-49623"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/hunter/marksmanship/TestMM.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,6 +1508,27 @@ dps_results: {
tps: 20372.66012
}
}
dps_results: {
key: "TestMM-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 22541.49473
tps: 20253.42057
}
}
dps_results: {
key: "TestMM-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 22541.49473
tps: 20253.42057
}
}
dps_results: {
key: "TestMM-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 22541.49473
tps: 20253.42057
}
}
dps_results: {
key: "TestMM-AllItems-Shadowmourne-49623"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/hunter/survival/TestSV.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,6 +1501,27 @@ dps_results: {
tps: 25581.18738
}
}
dps_results: {
key: "TestSV-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 28305.30571
tps: 25581.18738
}
}
dps_results: {
key: "TestSV-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 28305.30571
tps: 25581.18738
}
}
dps_results: {
key: "TestSV-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 28305.30571
tps: 25581.18738
}
}
dps_results: {
key: "TestSV-AllItems-Shadowmourne-49623"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/mage/arcane/TestArcane.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,6 +1424,27 @@ dps_results: {
tps: 33793.42963
}
}
dps_results: {
key: "TestArcane-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 38224.56479
tps: 34925.75513
}
}
dps_results: {
key: "TestArcane-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 37960.13615
tps: 34629.68476
}
}
dps_results: {
key: "TestArcane-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 38476.27966
tps: 35265.47943
}
}
dps_results: {
key: "TestArcane-AllItems-ShardofWoe-60233"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/mage/fire/TestFire.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,6 +1417,27 @@ dps_results: {
tps: 32809.92842
}
}
dps_results: {
key: "TestFire-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 37874.24137
tps: 33704.11639
}
}
dps_results: {
key: "TestFire-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 37916.36631
tps: 33740.11755
}
}
dps_results: {
key: "TestFire-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 38087.78658
tps: 33925.12738
}
}
dps_results: {
key: "TestFire-AllItems-ShardofWoe-60233"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/paladin/protection/TestProtection.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1428,6 +1428,27 @@ dps_results: {
tps: 53979.21063
}
}
dps_results: {
key: "TestProtection-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 10844.79153
tps: 54531.1142
}
}
dps_results: {
key: "TestProtection-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 10794.78325
tps: 54279.49883
}
}
dps_results: {
key: "TestProtection-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 10819.61801
tps: 54403.64029
}
}
dps_results: {
key: "TestProtection-AllItems-ShardofWoe-60233"
value: {
Expand Down
21 changes: 21 additions & 0 deletions sim/paladin/retribution/TestRetribution.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,6 +1445,27 @@ dps_results: {
tps: 36573.42377
}
}
dps_results: {
key: "TestRetribution-AllItems-SealoftheSevenSigns-77204"
value: {
dps: 36651.29333
tps: 36528.55175
}
}
dps_results: {
key: "TestRetribution-AllItems-SealoftheSevenSigns-77969"
value: {
dps: 36634.08458
tps: 36515.48666
}
}
dps_results: {
key: "TestRetribution-AllItems-SealoftheSevenSigns-77989"
value: {
dps: 36582.94349
tps: 36462.18116
}
}
dps_results: {
key: "TestRetribution-AllItems-Shadowmourne-49623"
value: {
Expand Down
Loading
Loading