Implement relative stat caps for "highest stat" trinket procs #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weights requests. These additional calculated values don't show up in the stat weights menu and can therefore be confusing to users, and should also be unnecessary since the auto-Reforge code already infers school-specific weights when missing. On branch feral Changes to be committed: modified: ui/core/components/stat_weights_action.tsx
of Khaz'goroth to proc a desired Stat. On branch feral Changes to be committed: modified: ui/core/components/suggest_reforges_action.tsx modified: ui/core/proto_utils/gear.ts
1337LutZ
reviewed
Jan 19, 2025
ui/core/proto_utils/gear.ts
Outdated
| @@ -163,6 +163,13 @@ export class Gear extends BaseGear { | |||
| .includes(itemId); | |||
| } | |||
|
|
|||
| hasTrinketFromOptions(itemIds: number[]): boolean { | |||
| return this.getTrinkets() | |||
| .filter(t => !!t) | |||
There was a problem hiding this comment.
A nicer way of doing this would be:
.filter((t): t is EquippedItem => !!t)
So you don't have to say t!.item.id in the map but you just handle the type guard better
1337LutZ
reviewed
Jan 19, 2025
| continue; | ||
| } | ||
|
|
||
| const trinketId = trinket!.item.id; |
There was a problem hiding this comment.
trinket! is the ! needed as you null check above?
1337LutZ
reviewed
Jan 19, 2025
| // If a highest Stat constraint is to be enforced, then update the associated | ||
| // coefficient if applicable. | ||
| if (this.relativeStatCap) { | ||
| this.relativeStatCap!.updateCoefficients(coefficients, stat, amount); |
There was a problem hiding this comment.
You could just do: this.relativeStatCap?.updateCoefficients(coefficients, stat, amount); so it will only execute when it's defined. Otherwise the ! is not needed since you null check in the if.
1337LutZ
reviewed
Jan 19, 2025
| const constraints = new Map<string, Constraint>(); | ||
|
|
||
| for (const slot of gear.getItemSlots()) { | ||
| constraints.set(ItemSlot[slot], lessEq(1)); | ||
| } | ||
|
|
||
| if (this.relativeStatCap) { | ||
| const statsWithoutBaseMastery = baseStats.addStat(Stat.StatMasteryRating, -this.player.getBaseMastery() * Mechanics.MASTERY_RATING_PER_MASTERY_POINT); | ||
| this.relativeStatCap!.updateConstraints(constraints, gear, statsWithoutBaseMastery); |
There was a problem hiding this comment.
Same here, the ! shouldn't be needed due to the null check in the if`
hillerstorm
approved these changes
Jan 19, 2025
On branch auto_reforge Changes to be committed: modified: ui/core/components/suggest_reforges_action.tsx modified: ui/core/proto_utils/gear.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.