[Feral] Talents Code Refactor #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phase so that they can be active during intermediate stats measurements, and make required changes so that final stats remain the same as before. On branch feral Changes to be committed: modified: sim/core/character.go modified: sim/druid/druid.go modified: sim/druid/feral/feral.go modified: sim/druid/forms.go modified: sim/druid/guardian/tank.go
after the refactor due to the form being Humanoid after deactivation of build phase auras. On branch feral Changes to be committed: modified: sim/druid/druid.go
tracker Aura utility in core. In addition to making the implementations compatible with item swapping, this refactor also makes the contribution of leather spec show up in the "Gear" section of the character stats breakdown, rather than showing up only in the total. On branch feral Changes to be committed: modified: sim/core/character.go modified: sim/druid/druid.go modified: sim/druid/forms.go
Cat Form Crit buff to be correctly attributed to "Talents" in the character sheet. On branch feral Changes to be committed: modified: sim/core/aura_helpers.go modified: sim/druid/forms.go modified: sim/druid/talents.go
allowing the Agi and Stam contributions to now show up in the character sheet Talents section. Full migration not possible currently due to the Bear Form healing logic. On branch feral Changes to be committed: modified: sim/druid/druid.go modified: sim/druid/forms.go modified: sim/druid/talents.go
Dodge buff shows up in the character sheet Talents contribution. On branch feral Changes to be committed: modified: sim/core/aura_helpers.go modified: sim/druid/forms.go modified: sim/druid/talents.go
Dodge buff to show up as a Talents contribution in the character sheet. On branch feral Changes to be committed: modified: sim/druid/forms.go modified: sim/druid/talents.go
stats display. On branch feral Changes to be committed: modified: sim/druid/forms.go modified: sim/druid/talents.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally figured out how to refactor things so that stat buffs + stat dependencies associated with a Druid form Aura can be applied during the appropriate character build phase for each effect. As a result, stat contributions in the UI stats display for the Feral and Guardian sims finally add up to the total value. This does come at a small performance cost due to chaining multiple callbacks for the form Auras vs. evaluating all effects in one function.