Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add fix for phase change filter when 0 #271

Merged
merged 2 commits into from
May 2, 2024

Conversation

1337LutZ
Copy link
Contributor

Partially fixes #247

  • Pre-patch is phase 0, thus the > 0 check had to be removed
  • Other filters don't work since sources is populated by AtlasLootClassic and there's no Cataclysm dataset yet.

@1337LutZ 1337LutZ changed the title [UI] Add fix for phase change 0 [UI] Add fix for phase change filter when 0 Apr 30, 2024
@rosenrusinov
Copy link
Contributor

We dont support pre-patch and never will in the backend so enabling it on the front end will only confuse users

@1337LutZ
Copy link
Contributor Author

We dont support pre-patch and never will in the backend so enabling it on the front end will only confuse users

Hmm, but the item filter is there, but just broken. Or should I just remove it instead?
image

@rosenrusinov
Copy link
Contributor

I think we're better off with removing the prepatch filter yes. It wont work anyway as the characters simmed will still be 85

@1337LutZ
Copy link
Contributor Author

1337LutZ commented May 1, 2024

I think we're better off with removing the prepatch filter yes. It wont work anyway as the characters simmed will still be 85

Resolved 👍

@rosenrusinov rosenrusinov merged commit 7f0c3bb into wowsims:master May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters do not apply correctly/at all when viewing sources of items
2 participants