Make Spell data from client database available in core #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is essentially a 1 to 1 translation of the same functionality in Simulationcraft)
I'm experimenting with making spell data from the client database files available for the sim to work with.
I achieve this by using the Simulationcraft client extractors (python) and modding them to extract to json instead. (this will be another repo I think)
What it contains:
I've made this available in a dbc package inside Core currently, and here's why I'm unsure and would love feedback/pushes on this branch on this.
It works right now for getting data from effects manually, and whatever we can get from the spell itself, Right now we return School, MissileSpeed, SpellSchool, cast time, gcd, cooldown and resource cost, pre parsing effects.
The future idea would be to build a complete spell with the data, and allow the possibility of overriding when the client is not enough.
Right now I tried modifying Kill Shot according to this and we go from
To
So compared to the old KS, I dont need to figure out what the average weapon damage is from effect1 or the Damage Multiplier from effect2, I also dont need to state gcd or cooldown, it also choses the correct spell school