[Rogue] Some small fixes after Beta testing, + Fix for DB Generator #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ades time reduction per combo point
kayla-glick
reviewed
Apr 6, 2024
Comment on lines
+29
to
+41
| if !isApplied { | ||
| comRogue.Eviscerate.DamageMultiplier *= multiplier | ||
| comRogue.Envenom.DamageMultiplier *= multiplier | ||
| comRogue.Rupture.DamageMultiplier *= multiplier | ||
| isApplied = true | ||
| } | ||
| }, | ||
| OnExpire: func(aura *core.Aura, sim *core.Simulation) { | ||
| comRogue.Eviscerate.DamageMultiplier /= multiplier | ||
| comRogue.Envenom.DamageMultiplier /= multiplier | ||
| comRogue.Rupture.DamageMultiplier /= multiplier | ||
| isApplied = false | ||
| aura.Deactivate(sim) |
There was a problem hiding this comment.
Revealing Strike is applied to each target as a debuff right? This implementation flat buffs the rogue's next strike regardless of target. I think the right way to do this would be to register a debuff on the target, then in the various finisher calculations, check if the buff is active and apply the multiplier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes some abilities function closer to their implementation on Beta, and adds a nil check to Assassin's Resolve to fix DB generation.