Warrior baseline spells #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes changes already in #37 so that should be merged first. |
…7/cata into warrior-baseline-spells
…-baseline-spells
kayla-glick
approved these changes
Apr 6, 2024
…or-baseline-spells
…ellMods and references to talents were removed. The talents will be handled during spec implementation by their own SpellMods.
rosenrusinov
approved these changes
Apr 11, 2024
sim/warrior/thunder_clap.go
Outdated
| ClassSpellMask: SpellMaskThunderClap, | ||
|
|
||
| RageCost: core.RageCostOptions{ | ||
| Cost: 20 - core.TernaryFloat64(warrior.HasMajorGlyph(proto.WarriorMajorGlyph_GlyphOfResonatingPower), 5, 0), |
There was a problem hiding this comment.
Can this be moved to the static spell mods?
There was a problem hiding this comment.
Oh it's already in there, forgot to remove this
sim/warrior/overpower.go
Outdated
Comment on lines
10
to
14
| opAura := warrior.RegisterAura(core.Aura{ | ||
| ActionID: core.ActionID{SpellID: 7384}, | ||
| Label: "Overpower Ready", | ||
| Duration: time.Second * 5, | ||
| }) |
There was a problem hiding this comment.
need to tag it with EnableOverpowerTag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well... I tried to keep it small.
Adds warrior spells shared across specs. Simple talents that affected said spells were also implemented, but anything more involved I'll handle as I'm implementing the talent trees and glyphs.