-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docs, Add Docker Releases & ARM64 Support #843
base: master
Are you sure you want to change the base?
Conversation
Very nice, thanks for this 👏 |
I want to merge this but without having access to my machine I wont be able to revert if I find something wrong. @1337LutZ @kayla-glick if you can find some time for this it would be lovely to merge. |
Synced branch, still looks fine. |
Merge conflict resolved due to test placement in main. |
@kayla-glick just a friendly reminder to review this one xx |
|
||
- Docker is available in OS X as well, so in theory similar instructions should work for the Docker method | ||
- You can also use the Ubuntu setup instructions as above to run natively, with a few modifications: | ||
- You may need a different Go installer if `go1.18.3.linux-amd64.tar.gz` is not compatible with your system's architecture; you can do the Go install manually from `https://go.dev/doc/install`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this still references an older Go version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably recommend that people download Go directly from the official Go website just to make sure that people get the right version for their architecture (thanks Apple)
# This allows for more rapid development, with sub second reloads on TS changes. This combines the benefits of `WATCH=1 make rundevserver` and `WATCH=1 make host` | ||
# to create something that allows you to work in any part of the code with ease and speed. | ||
# This might get rolled into `WATCH=1 make rundevserver` at some point. | ||
WATCH=1 make devmode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call out that this is the recommended way to run the server?
make items | ||
``` | ||
|
||
# Adding a Sim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions are all out-of-date at this point but since they were already that way no need to fix them in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things then ✅ . Sorry it took so long! I haven't been keeping up with Cata. Please feel free to ping me in the Discord if you need reviews!
No problems, thanks. I'll find some time over the next few days 😺 |
Alrighty so
README.md
, split development instructions into aDEVELOPMENT.md
to make the front page look less scary for "normies". Added docker instructions for those who wish.wowsimcli
binaries to.gitignore
makefile
to build and compress binaries for both amd64 and arm64 architectures. Docker image will be published in both amd64 and arm64 variants to support those who prefer cheaper hardware or want to run it on a NAS etc.makefile
to make it readable without crosseyedness.Closes #801