Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation timing improvements for Fire Mage APL #851

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Conversation

NerdEgghead
Copy link
Contributor

@NerdEgghead NerdEgghead commented Jul 16, 2024

  • Added API for querying the elapsed time since an Aura was last active.
  • Implemented AuraInactiveWithReactionTime APL value, which can be used to increase the realism of certain sims by blocking the re-application of non-clippable DoTs on the exact timestep when they expire.
  • Fixed APLActionWait to use the proper API for rescheduling the rotation action.
  • Fixed DotRemainingTime and AuraRemainingTime APL values to correctly return 0 for inactive auras.
  • Trigger reaction time waits after Living Bomb explosions for more consistent rotational behavior across small changes in the player's Haste value.
  • Added reaction time check to Living Bomb usage in Fire Mage APL, which blocks unrealistic casts on the exact nanosecond when a prior Living Bomb exploded. Also added a wait condition to block hardcasts when Living Bomb is nearly about to explode. Both of these changes suppress the fake DPS discontinuity when dropping total Haste from 3262 to 3261 by ~3x relative to the prior APL.
  • Removed MCD designation on Combustion so that it can be cast immediately after other spells in APLs.

 On branch rotation_timing
 Changes to be committed:
	modified:   sim/core/aura.go
introduce realism into certain sims by blocking the re-application of
non-clippable DoTs on the exact timestep when they expire.

 On branch rotation_timing
 Changes to be committed:
	modified:   proto/apl.proto
	modified:   sim/core/apl_value.go
	modified:   sim/core/apl_values_aura.go
	modified:   sim/core/aura.go
	modified:   ui/core/components/individual_sim_ui/apl_values.ts
action.

 On branch rotation_timing
 Changes to be committed:
	modified:   sim/core/apl_actions_timing.go
	modified:   sim/hunter/survival/TestSV.results
return 0 for inactive auras.

 On branch rotation_timing
 Changes to be committed:
	modified:   sim/core/apl_values_aura.go
	modified:   sim/core/apl_values_core.go
consistent rotational behavior across small changes in Haste value.

 On branch rotation_timing
 Changes to be committed:
	modified:   sim/mage/fire/TestFire.results
	modified:   sim/mage/living_bomb.go
blocks unrealistic casts on the exact nanosecond when a prior Living
Bomb exploded. Also added a wait condition to block hardcasts when
Living Bomb is nearly about to explode. Both of these changes suppress
the fake DPS discontinuity when dropping total Haste from 3262 to 3261
by ~3x relative to the prior APL.

 On branch rotation_timing
 Changes to be committed:
	modified:   sim/mage/fire/TestFire.results
	modified:   ui/mage/fire/apls/fire.apl.json
after other spells in APLs.

 On branch rotation_timing
 Changes to be committed:
	modified:   sim/mage/combustion.go
	modified:   sim/mage/fire/TestFire.results
@NerdEgghead NerdEgghead merged commit f91f2fe into master Jul 19, 2024
1 check passed
@NerdEgghead NerdEgghead deleted the rotation_timing branch July 19, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants