-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotation timing improvements for Fire Mage APL #851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch rotation_timing Changes to be committed: modified: sim/core/aura.go
introduce realism into certain sims by blocking the re-application of non-clippable DoTs on the exact timestep when they expire. On branch rotation_timing Changes to be committed: modified: proto/apl.proto modified: sim/core/apl_value.go modified: sim/core/apl_values_aura.go modified: sim/core/aura.go modified: ui/core/components/individual_sim_ui/apl_values.ts
action. On branch rotation_timing Changes to be committed: modified: sim/core/apl_actions_timing.go modified: sim/hunter/survival/TestSV.results
return 0 for inactive auras. On branch rotation_timing Changes to be committed: modified: sim/core/apl_values_aura.go modified: sim/core/apl_values_core.go
consistent rotational behavior across small changes in Haste value. On branch rotation_timing Changes to be committed: modified: sim/mage/fire/TestFire.results modified: sim/mage/living_bomb.go
blocks unrealistic casts on the exact nanosecond when a prior Living Bomb exploded. Also added a wait condition to block hardcasts when Living Bomb is nearly about to explode. Both of these changes suppress the fake DPS discontinuity when dropping total Haste from 3262 to 3261 by ~3x relative to the prior APL. On branch rotation_timing Changes to be committed: modified: sim/mage/fire/TestFire.results modified: ui/mage/fire/apls/fire.apl.json
after other spells in APLs. On branch rotation_timing Changes to be committed: modified: sim/mage/combustion.go modified: sim/mage/fire/TestFire.results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuraInactiveWithReactionTime
APL value, which can be used to increase the realism of certain sims by blocking the re-application of non-clippable DoTs on the exact timestep when they expire.APLActionWait
to use the proper API for rescheduling the rotation action.DotRemainingTime
andAuraRemainingTime
APL values to correctly return 0 for inactive auras.