Update API version in build-and-deploy workflow #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and commit a .deployedprotoversion if an API version change is detected. On branch versioning_workflow Changes to be committed: new file: .deployedprotoversion modified: .github/workflows/deploy.yml new file: sim/core/TestProtoVersioning.results
On branch versioning_workflow Changes to be committed: modified: .github/workflows/deploy.yml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our
build-and-deployGitHub Actions workflow to copy theTestProtoVersioning.resultsfile into a.deployedprotoversionreference file before running tests, and to automatically push this file tomasterif the version number was incremented in the merge commit that triggered the workflow. These two files are not currently used for anything, but are required for the proto versioning unit test that was added to #866 . I am PRing the workflow change separately from #866 in order to test that the workflow is functioning properly before finalizing the new unit test in #866 .