Code

Stat Ratings Refactor#883

Code

Merged

NerdEgghead merged 80 commits intomasterwowsims/cata:masterfrom stats_refactorwowsims/cata:stats_refactorCopy head branch name to clipboardAug 18, 2024

+40,311-40,593

Commits

Commits on Jul 28, 2024

• Committing only the proposed high-level structural changes to Stat /

  Show description for 3440160
  NerdEgghead

  committed
  3440160

  Copy full SHA for 3440160

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  c050603

  Copy full SHA for c050603

Commits on Jul 29, 2024

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  53b1475

  Copy full SHA for 53b1475

Commits on Jul 30, 2024

• Allow back-end Stats arrays to be larger than the arrays used in proto

  Show description for b272919
  NerdEgghead

  committed
  b272919

  Copy full SHA for b272919

• Migrated stats package to new schema

  Show description for d371820
  NerdEgghead

  committed
  d371820

  Copy full SHA for d371820

• Changed probability representation for tertiary stats to percentage

  Show description for d92eecd
  NerdEgghead

  committed
  d92eecd

  Copy full SHA for d92eecd

• Migrated base stats parser to new schema

  Show description for 7a6916a
  NerdEgghead

  committed
  7a6916a

  Copy full SHA for 7a6916a

• Renamed Rating <--> Percent conversion constants for clarity, and

  Show description for 50ad8f6
  NerdEgghead

  committed
  50ad8f6

  Copy full SHA for 50ad8f6

• Re-named BaseDodge and BaseParry PseudoStats to make their units

  Show description for 66b3cac
  NerdEgghead

  committed
  66b3cac

  Copy full SHA for 66b3cac

• Fixed typo in PhysicalHitRating PseudoStat name.

  Show description for a6d9434
  NerdEgghead

  committed
  a6d9434

  Copy full SHA for a6d9434

Commits on Jul 31, 2024

• Changed PseudoStats for bonus Hit/Crit taken to also be in percentage

  Show description for 2b75288
  NerdEgghead

  committed
  2b75288

  Copy full SHA for 2b75288

• Removed deprecated BonusCritRatingTaken PseudoStat, since no Cata

  Show description for a7fde60
  NerdEgghead

  committed
  a7fde60

  Copy full SHA for a7fde60

• Changed BonusHitRating and BonusCritRating Spell properties to

  Show description for 3386ce7
  NerdEgghead

  committed
  3386ce7

  Copy full SHA for 3386ce7

• Renamed ExpertisePercentage() helper to DodgeParrySuppression(), in

  Show description for cd58a7c
  NerdEgghead

  committed
  cd58a7c

  Copy full SHA for cd58a7c

• Removed BonusMeleeHitPercentTaken and BonusSpellHitPercentTaken

  Show description for f51d321
  NerdEgghead

  committed
  f51d321

  Copy full SHA for f51d321

• Renamed stats.FromFloatArray() to stats.FromProtoArray() and

  Show description for e7628af
  NerdEgghead

  committed
  e7628af

  Copy full SHA for e7628af

• Implemented universal stat dependencies between HitRating / CritRating

  Show description for ebe4c8f
  NerdEgghead

  committed
  ebe4c8f

  Copy full SHA for ebe4c8f

Commits on Aug 1, 2024

• Removed deprecated CharacterStatsTest() and StatWeightsTest() utility

  Show description for 1584671
  NerdEgghead

  committed
  1584671

  Copy full SHA for 1584671

• Cleaned up GetHighestStat() utility functions, and removed the redundant

  Show description for e9ed34e
  NerdEgghead

  committed
  e9ed34e

  Copy full SHA for e9ed34e

• Finished migrating core package to new schema

  Show description for 0993e14
  NerdEgghead

  committed
  0993e14

  Copy full SHA for 0993e14

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  f73b255

  Copy full SHA for f73b255

• Migrated warrior package

  Show description for e9a4527
  NerdEgghead

  committed
  e9a4527

  Copy full SHA for e9a4527

• Migrated druid package

  Show description for 6ae6a21
  NerdEgghead

  committed
  6ae6a21

  Copy full SHA for 6ae6a21

Commits on Aug 2, 2024

• Migrated warlock package

  Show description for 9dc603e
  NerdEgghead

  committed
  9dc603e

  Copy full SHA for 9dc603e

• Migrated paladin package

  Show description for e356c36
  NerdEgghead

  committed
  e356c36

  Copy full SHA for e356c36

• Migrated death_knight package

  Show description for 473c7d5
  NerdEgghead

  committed
  473c7d5

  Copy full SHA for 473c7d5

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  d394dbd

  Copy full SHA for d394dbd

• Migrated rogue package

  Show description for f9d7859
  NerdEgghead

  committed
  f9d7859

  Copy full SHA for f9d7859

• Migrated mage package

  Show description for 19f5673
  NerdEgghead

  committed
  19f5673

  Copy full SHA for 19f5673

Commits on Aug 4, 2024

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  eabb674

  Copy full SHA for eabb674

Commits on Aug 5, 2024

• Migrated shaman package

  Show description for 9e5395f
  NerdEgghead

  committed
  9e5395f

  Copy full SHA for 9e5395f

• Migrated priest package

  Show description for 9f0665f
  NerdEgghead

  committed
  9f0665f

  Copy full SHA for 9f0665f

• Migrated encounters package

  Show description for 3570c4f
  NerdEgghead

  committed
  3570c4f

  Copy full SHA for 3570c4f

• Migrated common package

  Show description for 1f3c0aa
  NerdEgghead

  committed
  1f3c0aa

  Copy full SHA for 1f3c0aa

• Migrated hunter package

  Show description for 79ba1d3
  NerdEgghead

  committed
  79ba1d3

  Copy full SHA for 79ba1d3

• Switch to percentage units for tertiary PseudoStats in the front-end, in

  Show description for 00e4c01
  NerdEgghead

  committed
  00e4c01

  Copy full SHA for 00e4c01

• Renamed UnitStat proto to UIStat for clarity

  Show description for ae6a8b9
  NerdEgghead

  committed
  ae6a8b9

  Copy full SHA for ae6a8b9

Commits on Aug 6, 2024

• Migrated DB generation code and re-built the database under the new

  Show description for 987614a
  NerdEgghead

  committed
  987614a

  Copy full SHA for 987614a

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  b8845da

  Copy full SHA for b8845da

• Fixed base Hot Streak proc chance calculation to match old value.

  Show description for 2223744
  NerdEgghead

  committed
  2223744

  Copy full SHA for 2223744

• Fixed Hunter pet stat inheritance to match old calculation

  Show description for 96390e4
  NerdEgghead

  committed
  96390e4

  Copy full SHA for 96390e4

• Updated Warlock test files so they run

  Show description for 0cb7e02
  NerdEgghead

  committed
  0cb7e02

  Copy full SHA for 0cb7e02

• Updated spec sim test results. Aside from Demonology Warlock, the only

  Show description for ef4bee2
  NerdEgghead

  committed
  ef4bee2

  Copy full SHA for ef4bee2

• Migrated remaining core test files so they run

  Show description for 7683b4c
  NerdEgghead

  committed
  7683b4c

  Copy full SHA for 7683b4c

• Migrated old TBC effects code

  Show description for c7cdf29
  NerdEgghead

  committed
  c7cdf29

  Copy full SHA for c7cdf29

• Removed equal length check in stats test, since SimStatsLen can now

  Show description for 853dd8f
  NerdEgghead

  committed
  853dd8f

  Copy full SHA for 853dd8f

• Fixed missing factor of 100 in exported HastePercent PseudoStats

  Show description for 9d02ebf
  NerdEgghead

  committed
  9d02ebf

  Copy full SHA for 9d02ebf

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  b27a30c

  Copy full SHA for b27a30c

• Intentionally bugged PhysicalCritChance() calculation to match Curse of

  Show description for 377a9c1
  NerdEgghead

  committed
  377a9c1

  Copy full SHA for 377a9c1

• Fixed bug where Curse of Gul'dan is applying 0.1 Melee Crit Rating on

  Show description for 5d78cad
  NerdEgghead

  committed
  5d78cad

  Copy full SHA for 5d78cad

Commits on Aug 8, 2024

• Refactored front-end stats representations and conversion constants to

  Show description for 464789e
  NerdEgghead

  committed
  464789e

  Copy full SHA for 464789e

• Added support for PseudoStat EP calculations in unit tests, and included

  Show description for 562fa23
  NerdEgghead

  committed
  562fa23

  Copy full SHA for 562fa23

• Moved PseudoStat EP test case from Guardian to Assassination for a

  Show description for eb77c1d
  NerdEgghead

  committed
  eb77c1d

  Copy full SHA for eb77c1d

• Implemented logic to remove HitRating and CritRating from stat weights

  Show description for 5bf4482
  NerdEgghead

  committed
  5bf4482

  Copy full SHA for 5bf4482

• Added front-end logic to automatically add relevant school-specific

  Show description for 082c3ec
  NerdEgghead

  committed
  082c3ec

  Copy full SHA for 082c3ec

• Migrated all front-end spec sim config files

  Show description for f674616
  NerdEgghead

  committed
  f674616

  Copy full SHA for f674616

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  cda2526

  Copy full SHA for cda2526

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  30c287d

  Copy full SHA for 30c287d

• Changed statOrder constant to be an array of UnitStat objects rather

  Show description for 9c7e62b
  NerdEgghead

  committed
  9c7e62b

  Copy full SHA for 9c7e62b

• Migrated database.ts

  Show description for e7ea24d
  NerdEgghead

  committed
  e7ea24d

  Copy full SHA for e7ea24d

• Migrated player.ts

  Show description for b3b5f1a
  NerdEgghead

  committed
  b3b5f1a

  Copy full SHA for b3b5f1a

Commits on Aug 9, 2024

• Created proper TypeScript class to facilitate operations on

  Show description for bcd583d
  NerdEgghead

  committed
  bcd583d

  Copy full SHA for bcd583d

Commits on Aug 10, 2024

• Migrated Suggest Reforges code and added additional UnitStat utilities

  Show description for 05b0b02
  NerdEgghead

  committed
  05b0b02

  Copy full SHA for 05b0b02

Commits on Aug 15, 2024

• Merge branch 'master' into stats_refactor

  Show description for c4dc9e4
  NerdEgghead

  committed
  c4dc9e4

  Copy full SHA for c4dc9e4

• Removed unused Suggest Gems code from WotLK. Even if we implement this

  Show description for 485a626
  NerdEgghead

  committed
  485a626

  Copy full SHA for 485a626

• Migrated inputs modules

  Show description for c4cbaef
  NerdEgghead

  committed
  c4cbaef

  Copy full SHA for c4cbaef

• Migrated reforge_summary

  Show description for ea8d86c
  NerdEgghead

  committed
  ea8d86c

  Copy full SHA for ea8d86c

• Migrated gear_picker modules

  Show description for 8807e02
  NerdEgghead

  committed
  8807e02

  Copy full SHA for 8807e02

• Migrated exporters

  Show description for e7783df
  NerdEgghead

  committed
  e7783df

  Copy full SHA for e7783df

• Migrated encounter_picker

  Show description for bf6a2ed
  NerdEgghead

  committed
  bf6a2ed

  Copy full SHA for bf6a2ed

• Migrated character stats code, everything now compiles.

  Show description for 690e2df
  NerdEgghead

  committed
  690e2df

  Copy full SHA for 690e2df

• Fixed circular imports between names.ts and stats.ts, and cleaned up

  Show description for a7bfd7e
  NerdEgghead

  committed
  a7bfd7e

  Copy full SHA for a7bfd7e

Commits on Aug 16, 2024

• Incremented API version, and implemented front-end migration functions

  Show description for ee1d349
  NerdEgghead

  committed
  ee1d349

  Copy full SHA for ee1d349

• Fixed two crashes associated with Reforge code: (1) implemented a

  Show description for a700108
  NerdEgghead

  committed
  a700108

  Copy full SHA for a700108

• Removed soft cap breakpoints from IndividualSimSettings proto, since

  Show description for fcdeb9d
  NerdEgghead

  committed
  fcdeb9d

  Copy full SHA for fcdeb9d

• Fixed a bug where Reforge variables were not being set, and cleaned up

  Show description for 1c31a45
  NerdEgghead

  committed
  1c31a45

  Copy full SHA for 1c31a45

• Hide Rating component of displayed stat strings when the value is 0,

  Show description for 161576c
  NerdEgghead

  committed
  161576c

  Copy full SHA for 161576c

• Display preset Reforge cap selections as % rather than Rating for

  Show description for dcefef7
  NerdEgghead

  committed
  dcefef7

  Copy full SHA for dcefef7

Commits on Aug 17, 2024

• Fixed a bug with Bonus Stats migration from old links / presets.

  Show description for ecc9f52
  NerdEgghead

  committed
  ecc9f52

  Copy full SHA for ecc9f52

Commits on Aug 18, 2024

• Merge branch 'master' into stats_refactor

  NerdEgghead

  committed
  6d53502

  Copy full SHA for 6d53502