[WARLOCK] Add random cast delay to Doomguard #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When plotting breakpoints and stat scaling I found out that Doomguard has massive peaks at certain fixed haste breakpoints. After some digging together with Ketesh, TheNameLess and Malvanis in the Warlock Discord we found that it is related to Doomguard gaining a extra cast.
The fixed 400ms cast delay is however not "game like" and should be changed. I've analysed 1700+ Doomguard casts in logs and created the following Histogram highlighting a more accurate interpretation:
We came to the consensus to set the cast delay to a random number between 150 and 750ms.
Results
Stat scaling
Before: https://docs.google.com/spreadsheets/d/e/2PACX-1vSOhHz6EmXS4SOdfz8MCdXkx9jzOP0_7yhGreE_HeUIjSjxdXv3rMXLYacYfwEWudM3cA00O1ndgc4Z/pubchart?oid=1571781985&format=interactive
After: https://docs.google.com/spreadsheets/d/e/2PACX-1vSOhHz6EmXS4SOdfz8MCdXkx9jzOP0_7yhGreE_HeUIjSjxdXv3rMXLYacYfwEWudM3cA00O1ndgc4Z/pubchart?oid=840962925&format=interactive
Breakpoints
Before: https://docs.google.com/spreadsheets/d/e/2PACX-1vSOhHz6EmXS4SOdfz8MCdXkx9jzOP0_7yhGreE_HeUIjSjxdXv3rMXLYacYfwEWudM3cA00O1ndgc4Z/pubchart?oid=303894196&format=interactive
After: https://docs.google.com/spreadsheets/d/e/2PACX-1vSOhHz6EmXS4SOdfz8MCdXkx9jzOP0_7yhGreE_HeUIjSjxdXv3rMXLYacYfwEWudM3cA00O1ndgc4Z/pubchart?oid=1405742270&format=interactive