Automatic item release phase inference #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NerdEgghead
commented
Aug 19, 2024
NerdEgghead
commented
- Implemented automatic phase detection for items with missing phase information on Wowhead, using a combination of ilvl + source heuristics. These heuristics are not perfect by any means, but still a significant improvement over the status quo.
- Re-enabled phase filtering on UI item lists, and added selectors for all Cata Classic phases.
Cata Classic phases. On branch infer_phase Changes to be committed: modified: ui/core/components/gear_picker/item_list.tsx modified: ui/core/components/inputs/other_inputs.ts modified: ui/core/constants/other.ts
On branch infer_phase Changes to be committed: modified: assets/database/db.bin modified: assets/database/db.json modified: tools/database/gen_db/main.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.